Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DSRC-112: FeaturedExternalLinkBlock #1730

Merged
merged 7 commits into from
Oct 18, 2024

Conversation

jamesbiggs
Copy link
Collaborator

@jamesbiggs jamesbiggs commented Oct 17, 2024

Ticket URL: DSRC-112

About these changes

Adds a FeaturedExternalLinkBlock to the General and BlogPostPage, as well as EtC pages.

Also adds the hero image component to BlogPostPages DSRC-121, and removes "link list" from GeneralPages.

Before assigning to reviewer, please make sure you have

  • Checked things thoroughly before handing over to reviewer
  • Checked PR title starts with ticket number as per project conventions to help us keep track of changes
  • Ensured that PR includes only commits relevant to the ticket
  • Waited for all CI jobs to pass before requesting a review
  • Added/updated tests and documentation where relevant

Merging PR guidance

Follow docs\developer-guide\contributing.md

Deployment guidance

Follow docs\infra\environments.md

@jamesbiggs jamesbiggs changed the title Feature/DSRC-112-featured-external-link DSRC-112: FeaturedExternalLinkBlock Oct 17, 2024
@ahosgood ahosgood merged commit c0a9f5d into develop Oct 18, 2024
8 checks passed
@ahosgood ahosgood deleted the feature/DSRC-112-featured-external-link branch October 18, 2024 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants