Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prototype: Record detail view image viewer prototype (DO NOT MERGE) #1526

Closed
wants to merge 100 commits into from
Closed

Prototype: Record detail view image viewer prototype (DO NOT MERGE) #1526

wants to merge 100 commits into from

Conversation

tm-kn
Copy link
Contributor

@tm-kn tm-kn commented Feb 14, 2024 •
edited
Loading

https://national-archives.atlassian.net/browse/DOR-23

Tidy ups:

  • Replace the demo version of fetching results with proper Rosetta manifest fetch.
  • Delete inline/full variant URLs and rename templates/views as "the only" record detail view.
  • Record Detail View template: remove or implement the hard-coded "related website content" and "records in the same series" elements.
  • Rename the record bridge FE component to something better.

@tm-kn tm-kn changed the base branch from develop to etna-rosetta February 14, 2024 16:50
tm-kn and others added 23 commits February 14, 2024 17:01
@tm-kn
Fix linting issues
ef42c85
@tm-kn
Fix isort issues
79e2e3b
@tm-kn
Fix black issues
b485ae2
@tm-kn
Fix isort issues
dcdab06
update record detail template in line with new designs (includes some…
4797460 
… hardcoded data)
@ahosgood
Add deployment for experiment/image-viewer
808b257
@ahosgood
Remove Slack notification from deployment
f19c1cd
@ahosgood
Bump SCSS
a9dd2bb
@ahosgood
Lint SCSS
786b640
@ahosgood
Don't test or lint code to push to experiment/image-viewer
51df1d8
@ahosgood
Lint SCSS
5e1fe89
@ahosgood
Change environment name to exp/image-viewer
8f0a215
@ahosgood
Bump SCSS
cce31e4
@ahosgood
Merge branch 'develop' of github.com:nationalarchives/ds-wagtail into…
803791d 
… experiment/image-viewer
@ahosgood
Change environment name to expimage-viewer
f881765
@ahosgood
Remove collectstatic
a413569
@ahosgood
Re-add collectstatic
0d7f36f
@ahosgood
Fix FA path for new icon
f276825
add related records and website content sections (hard coded)
3c4deaa
add jumplinks
b616d62
remove custom background and use template classes. update containers …
b932417 
…for full width version
fix UV container cutting off at full screen
491d53e
tidy up sass
5ba9c10
Jane and others added 27 commits March 14, 2024 17:19
update icon, remove download and share options and remove click to zoom
12ec7f7
@tm-kn
Use separate session object for IIIF manifests
f6f1393
@tm-kn
strtobool to return bool, not an integer
3de0ae7
@tm-kn
Change comment for the strtobool function
e7a75b8
Merge branch 'fix/universal-viewer-refinements' into experiment/image…
e100255 
…-viewer

* fix/universal-viewer-refinements:
  update icon, remove download and share options and remove click to zoom
Merge branch 'develop' into experiment/image-viewer
11ace71 
* develop: (25 commits)
  Make strtobool() return a boolean value, not an integer (0, 1) (#1565)
  Update 0009_alter_eventpage_venue_type_and_more.py (#1563)
  Update 0004_eventsession_session_id.py to include max_length here
  Added `max_length` to `session_id` and `venue_type` (#1562)
  Change topic and time period images from 900x400 to 600x400
  Update TNA Frontend (#1466)
  EDEV-89: Fix media chooser (#1559)
  Introduce APIRichTextBlock (#1504)
  EDEV-32: Article Pages API response (#1534)
  EDEV-87: Fix "Download XLSX" and "CSV" dropdown (#1553)
  Release 24.03.05.28
  Bump cryptography from 42.0.2 to 42.0.4
  Update config for WAGTAIL_HEADLESS_PREVIEW
  Update GitHub Action versions to use Node 20
  Update wagtail-headless-preview
  Add WAGTAIL_HEADLESS_PREVIEW for production
  Release 24.03.05.27
  Flake8 compliance
  Update GitHub Action versions to use Node 20
  isort compliance
  ...

# Conflicts:
#	config/settings/util.py
#	etna/search/tests/test_native_website_search.py
#	package-lock.json
#	package.json
#	sass/etna.scss
#	sass/includes/_image-block.scss
#	sass/includes/_media-embed.scss
#	sass/includes/_meta-details-banner.scss
#	sass/includes/_people.scss
#	sass/includes/_transcription.scss
#	sass/includes/search/_search-results-hero.scss
#	templates/includes/header.html
#	templates/search/blocks/search_pagination.html
#	templates/search/blocks/search_results__list-card--grid.html
#	templates/search/blocks/search_results__list-card.html
#	templates/search/blocks/search_results_hero.html
#	templates/search/includes/results-details.html
@tm-kn
Add merge migration
8638d25
@tm-kn
Add a missing migration
f095cc5
@tm-kn
Merge remote-tracking branch 'origin/develop' into experiment/image-v…
6458556 
…iewer
@jamesbiggs
Merge branch 'etna-rosetta' into experiment/image-viewer
06ea1e7
add images to related website content component
374c79c
@tm-kn
Re-enable share and download on IIIF viewer
f56d524
@tm-kn
Add a merge migration
80833ac
@tm-kn
Allow alterfield in migrations
bdb3dff
@tm-kn
Add a missing migration
28cb24b
@tm-kn
[DOR-69] Add return to search link on record detail page (#1573)
c4f7b29 
Co-authored-by: Tomasz Knapik <[email protected]>
@tm-kn
DOR-70: Record viewer updates following internal feedback (#1575)
c0d9b2a 
Co-authored-by: Tomasz Knapik <[email protected]>
[DOR-77] Add images & working links to cards in related website conte…
4a4cbf9 
…nt component (#1576)
re-add story page title and hero image which was unintentionally remo…
bdd59f9 
…ved as part of template updates
@tm-kn
Use correct var in template
6f1cbdf
update width of 'total' page count
5612837
update related website content links
fd4a4ce
Merge branch 'feature/DOR-77-related-website-content' into experiment…
182cdef 
…/image-viewer

* feature/DOR-77-related-website-content:
  update related website content links
  add images to related website content component

# Conflicts:
#	templates/records/record_detail.html
Fix: Updates 'record viewer' heading styles to match others on page (#…
dc8d1d9 
…1583)
[DOR-81]: Temporarily hide records without thumbnails from search res…
c548b4e 
…ults (#1581)
[chore] Update .env.example with rosetta prefix (#1586)
a9cb65f
[DOR-79] Fix sidebar / jumplinks focus state being cut off (#1589)
f4bf30b
@janehughes janehughes mentioned this pull request Mar 28, 2024
Closed
5 tasks
@ahosgood ahosgood closed this Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tm-kn @ahosgood @jamesbiggs