Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DF-815-<fieldset> structures within the catalogue search results page. #1330

Merged
merged 15 commits into from
Sep 22, 2023

Conversation

JohnHeeryTNA
Copy link
Collaborator

Ticket URL: https://national-archives.atlassian.net/jira/software/projects/DF/issues/DF-815

About these changes

Implementing

tags around 'To' and 'From' date ranges on catalogue search results page

How to check these changes

Perform a search, go to catalogue results, filter by date ranges to ensure this is working correctly.

Before assigning to reviewer, please make sure you have

  • Checked things thoroughly before handing over to reviewer.
  • Checked PR title starts with ticket number as per project conventions to help us keep track of changes.
  • Ensured that PR includes only commits relevant to the ticket.
  • Waited for all CI jobs to pass before requesting a review.
  • Added/updated tests and documentation where relevant.

Merging PR guidance

Follow docs\developer-guide\contributing.md

Deployment guidance

Follow docs\infra\environments.md

…ationalarchives/ds-wagtail into fix/fix-fieldset-accessibility

# Please enter a commit message to explain why this merge is necessary,
# especially if it merges an updated upstream into a topic branch.
#
# Lines starting with '#' will be ignored, and an empty message aborts
# the commit.
JohnHeeryTNA and others added 3 commits September 21, 2023 14:38
…ationalarchives/ds-wagtail into fix/fix-fieldset-accessibility

# Please enter a commit message to explain why this merge is necessary,
# especially if it merges an updated upstream into a topic branch.
#
# Lines starting with '#' will be ignored, and an empty message aborts
# the commit.
@JohnHeeryTNA JohnHeeryTNA merged commit 1ee1400 into develop Sep 22, 2023
7 checks passed
@JohnHeeryTNA JohnHeeryTNA deleted the fix/fix-fieldset-accessibility branch September 22, 2023 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants