Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DF-800: add fields to details page #1286

Merged
merged 12 commits into from
Aug 29, 2023

Conversation

TNA-Allan
Copy link
Collaborator

@TNA-Allan TNA-Allan commented Aug 29, 2023

Ticket URL: https://national-archives.atlassian.net/browse/DF-800

About these changes

  • Added TNA Catalogue fields to the record details page
  • Updated Related Materials (removed li)

How to check these changes

see Catalogue Data Elements XLS for the attributes added with examples
Example:
http://127.0.0.1:8000/catalogue/id/C8672907/

Before assigning to reviewer, please make sure you have

  • Checked things thoroughly before handing over to reviewer.
  • Checked PR title starts with ticket number as per project conventions to help us keep track of changes.
  • Ensured that PR includes only commits relevant to the ticket.
  • Waited for all CI jobs to pass before requesting a review.
  • Added/updated tests and documentation where relevant.

Merging PR guidance

Follow docs\developer-guide\contributing.md

Deployment guidance

Follow docs\infra\environments.md

Copy link
Collaborator

@jamesbiggs jamesbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work Allan 😎

@TNA-Allan TNA-Allan merged commit ccd14c8 into develop Aug 29, 2023
6 checks passed
@jamesbiggs jamesbiggs deleted the feature/DF-800-add-fields-to-details-page branch August 29, 2023 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants