Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/DF-317 screen reader see more link #1270

Merged
merged 3 commits into from
Aug 14, 2023

Conversation

JohnHeeryTNA
Copy link
Collaborator

Ticket URL: https://national-archives.atlassian.net/jira/software/projects/DF/issues/DF-317

About these changes

Adding an aria-label attribute for the 'See more' link (Long filters)

How to check these changes

Check search results page : Catalogue / Website, check that 'See more' link is read by screen reader in form mode

Before assigning to reviewer, please make sure you have

  • Checked things thoroughly before handing over to reviewer.
  • Checked PR title starts with ticket number as per project conventions to help us keep track of changes.
  • Ensured that PR includes only commits relevant to the ticket.
  • Waited for all CI jobs to pass before requesting a review.
  • Added/updated tests and documentation where relevant.

Merging PR guidance

Follow docs\developer-guide\contributing.md

Deployment guidance

Follow docs\infra\environments.md

Copy link

@sdwilkes sdwilkes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved for testing, thanks.

@JohnHeeryTNA JohnHeeryTNA merged commit 2339457 into develop Aug 14, 2023
3 checks passed
@JohnHeeryTNA JohnHeeryTNA deleted the fix/DF-317-screen-reader-see-more-link branch August 14, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants