Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Df-772 apply styling to website results #1195

Merged
merged 13 commits into from
Jul 19, 2023

Conversation

JohnHeeryTNA
Copy link
Collaborator

Ticket URL: https://national-archives.atlassian.net/browse/DF-772

About these changes

Width adjustment when only one result is returned

How to check these changes

Please perform searches and check the layout on the 'All Results' tab across all breakpoints

Before assigning to reviewer, please make sure you have

  • Checked things thoroughly before handing over to reviewer.
  • Checked PR title starts with ticket number as per project conventions to help us keep track of changes.
  • Ensured that PR includes only commits relevant to the ticket.
  • Waited for all CI jobs to pass before requesting a review.
  • Added/updated tests and documentation where relevant.

Merging PR guidance

Follow docs\developer-guide\contributing.md

Deployment guidance

Follow docs\infra\environments.md

JohnHeeryTNA and others added 12 commits July 13, 2023 14:33
…hub.com/nationalarchives/ds-wagtail into DF-772-apply-styling-to-website-results

# Please enter a commit message to explain why this merge is necessary,
# especially if it merges an updated upstream into a topic branch.
#
# Lines starting with '#' will be ignored, and an empty message aborts
# the commit.
…hub.com/nationalarchives/ds-wagtail into DF-772-apply-styling-to-website-results

# Please enter a commit message to explain why this merge is necessary,
# especially if it merges an updated upstream into a topic branch.
#
# Lines starting with '#' will be ignored, and an empty message aborts
# the commit.
@JohnHeeryTNA JohnHeeryTNA changed the title Df 772 apply styling to website results Df-772 apply styling to website results Jul 19, 2023
@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

Merging #1195 (0c11193) into develop (2f55c23) will increase coverage by 0.08%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop    #1195      +/-   ##
===========================================
+ Coverage    83.36%   83.45%   +0.08%     
===========================================
  Files          115      115              
  Lines         4377     4399      +22     
===========================================
+ Hits          3649     3671      +22     
  Misses         728      728              
Impacted Files Coverage Δ
etna/records/templatetags/records_tags.py 100.00% <100.00%> (ø)
etna/search/templatetags/search_tags.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link

@sdwilkes sdwilkes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved for testing on Develop, thanks @JohnHeeryTNA

@sdwilkes sdwilkes merged commit ba2f7ff into develop Jul 19, 2023
5 checks passed
@jamesbiggs jamesbiggs deleted the DF-772-apply-styling-to-website-results branch August 1, 2023 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants