Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds additional BMS entities for H1 G2 and KH inverters on latest firmware #735

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

FozzieUK
Copy link
Contributor

@FozzieUK FozzieUK commented Jan 19, 2025

Adds additional BMS entities for H1 G2 and KH inverters running with latest firmware

On H1 G2 inverter this PR will add these entities-

bms_cell_temp_high
bms_cell_temp_low
bms_cell_mv_high
bms_cell_mv_low
batvolt
bat_current
inverter_fault_code

Note for the G2 this update is sensitive to firmware version:

On the H1 G2, if you have Manager: 1.37, Master: 1.22 it will not support all the BMS registers - either upgrade to the latest firmware or in the integration configure the settings and enter the manager version of 1.44
also note Manager firmware 1.44 has incorrect scale on bms_cell_mV, low/high (this is a Fox bug, upgrade to Manager 1.48 to fix this)

see #712

On KH inverter this PR will add these missing BMS entities-

bms_cell_temp_high
bms_cell_temp_low
bms_cell_mv_high
bms_cell_mv_low
bms_kwh_remaining

see #740 (comment)

On H1 G2 inverter adds these entities bms_cell_temp_high, bms_cell_temp_low, bms_cell_mv_high, bms_cell_mv_low, batvolt, bat_current and inverter_fault_code.

Note this is firmware sensitive and requires latest H1 G2 firmware (Master 1.48, Manager 1.31) note the following

Manager: 1.37, Master: 1.22 does not support all of the BMS registers (it will error on batvolt and batcurrent)

Manager 1.44, Master 1.27 does support all the BMS registers but the scale is incorrect on bms_cell_mV-low/high

Manager 1.48, Master 1.31 supports all the BMS registers and the scale is correct on bms_cell_mV-low/high

see nathanmarlor#712
@canton7
Copy link
Collaborator

canton7 commented Jan 22, 2025

Thanks!

I've finally got around to putting in support for different manager versions (#739), so we can add these and not break everyone.

That will require a little bit of reword of the PR though: have two Inv members for the two H1_G2 version ranges (and maybe a H1_G2_ALL for convience), and update entity_descriptions.py.

@FozzieUK
Copy link
Contributor Author

ok thanks!, i'll update my branch with all the latest changes, have a quick read through to digest the version stuff and go from there

inverters running with latest firmware

On H1 G2 inverter this PR will add these entities-

bms_cell_temp_high
bms_cell_temp_low
bms_cell_mv_high
bms_cell_mv_low
batvolt
bat_current
inverter_fault_code

Note this update is firmware version sensitive

If you have Manager: 1.37, Master: 1.22 it will not support all the
BMS registers - either upgrade to the latest firmware or configure the
integration and in settings enter the manager version 1.44

WIth Manager firmware 1.44 the scale is incorrect on bms_cell_mV,
low/high (a Fox bug, upgrade to Manager to fix this 1.48)

Manager 1.48, Master 1.31 supports all the BMS registers

On KH inverter this PR will add these missing BMS entities-

bms_cell_temp_high
bms_cell_temp_low
bms_cell_mv_high
bms_cell_mv_low
bms_kwh_remaining
@FozzieUK FozzieUK changed the title Adds additional BMS entities for H1 G2 inverter on latest firmware Adds additional BMS entities for H1 G2 and KH inverters on latest firmware Jan 23, 2025
@FozzieUK
Copy link
Contributor Author

FozzieUK commented Jan 23, 2025

@canton7 i've made the following changes -

2 new Inv members H1_G2_PRE144 and H1_G2_144 - I have left the original H1_G2 name but made it the equivalent of 'SET' (I kept the original name as it is used throughout and 95% of the entities are in it)

If config version is entered for 1,44 it will select H1_G2_PRE144 otherwise H1_G2_144

I also extended to the KH and added in BMS cell volts, temps and kwh_remaining as per #740 (comment)

EDIT: Can we pre-release as a beta and find a few candidate testers before we let this go wild.

@WyndStryke
Copy link

EDIT: Can we pre-release as a beta and find a few candidate testers before we let this go wild.

I'll be happy to represent the post-1.33 KH contingent :-)

@canton7
Copy link
Collaborator

canton7 commented Jan 24, 2025

@FozzieUK Perfect, thanks!

I have left the original H1_G2 name but made it the equivalent of 'SET' (I kept the original name as it is used throughout and 95% of the entities are in it)

I might be tempted to rename it anyway for consistency -- then someone reading entity_descriptions can see quickly that it refers to more than one inverter.

If config version is entered for 1,44 it will select H1_G2_PRE144 otherwise H1_G2_144

👍 . I'm tempted to rename the Inv members to better match how Version is used, but I'll do that in one go later.

EDIT: Can we pre-release as a beta and find a few candidate testers before we let this go wild.

Yep I think that makes sense. I should have some time on Sunday.

consistency with other inverter models
@FozzieUK
Copy link
Contributor Author

I might be tempted to rename it anyway for consistency -- then someone reading entity_descriptions can see quickly that it refers to more than one inverter.

No problem, it was bothering me too - i've updated it so now H1_G2 is H1_G2_SET

If config version is entered for 1,44 it will select H1_G2_PRE144 otherwise H1_G2_144

I'm tempted to rename the Inv members to better match how Version is used, but I'll do that in one go later.

Perfect, thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants