Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use PosixPollSerial from pyserial for serial connections where possible #461

Merged
merged 1 commit into from
Nov 4, 2023
Merged

Use PosixPollSerial from pyserial for serial connections where possible #461

merged 1 commit into from
Nov 4, 2023

Conversation

canton7
Copy link
Collaborator

@canton7 canton7 commented Nov 4, 2023

This uses poll rather than select, which means we're not limited to 1024 fds.

Fixes: #457

@canton7
Use PosixPollSerial from pyserial for serial connections where possible
bef5065 
This uses poll rather than select, which means we're not limited to 1024 fds.

Fixes: nathanmarlor#457
@canton7 canton7 merged commit 1b88ce9 into nathanmarlor:main Nov 4, 2023
3 checks passed
@canton7 canton7 deleted the bugfix/serial-select branch November 4, 2023 12:11
canton7 added a commit to canton7/foxess_modbus that referenced this pull request Nov 29, 2023
@canton7
Revert "Merge pull request nathanmarlor#461 from canton7/bugfix/seria…
3cb2589 
…l-select"

This reverts commit 1b88ce9, reversing
changes made to 592624c.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Serial connections fail when there are many open fds
1 participant
@canton7