Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump @iconify/tools to fix type errors #230

Merged
merged 3 commits into from
Aug 16, 2024

Conversation

frankievalentine
Copy link
Contributor

Iconify tools had a type error with a specific 'cheerio' package that caused astro-icon to fail on build with Astro. Bumping the package fixes the type error.

See this issue for more details: #210

Copy link

changeset-bot bot commented Aug 9, 2024

🦋 Changeset detected

Latest commit: 997b706

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
astro-icon Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Aug 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api-astroicon ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 16, 2024 7:41pm
astroicon ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 16, 2024 7:41pm

@dan-mba
Copy link

dan-mba commented Aug 14, 2024

@frankievalentine The pnpm-lock file needs to be updated for the change to be picked up.

Copy link
Owner

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

Iconify tools had a type error with a specific 'cheerio' package that caused astro-icon to fail on build with Astro. Bumping the package fixes the type error.

See this issue for more details: natemoo-re#210
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

depedency @iconify/tools v3 comes with incorrect types for cheerio (fixed in v4)
3 participants