Fix sensor to use native unit of measurement and improve reauth flow

natekspencer · May 17, 2022 · 35a7984 · 35a7984
1 parent b1ca362
commit 35a7984
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 15 deletions.
diff --git a/custom_components/vivint/__init__.py b/custom_components/vivint/__init__.py
@@ -60,7 +60,7 @@ async def async_setup_entry(hass: HomeAssistant, entry: ConfigEntry) -> bool:
     except (VivintSkyApiMfaRequiredError, VivintSkyApiAuthenticationError) as ex:
         raise ConfigEntryAuthFailed(ex) from ex
     except (VivintSkyApiError, ClientResponseError, ClientConnectorError) as ex:
-        raise ConfigEntryNotReady from ex
+        raise ConfigEntryNotReady(ex) from ex
 
     dev_reg = await device_registry.async_get_registry(hass)
 

diff --git a/custom_components/vivint/config_flow.py b/custom_components/vivint/config_flow.py
@@ -64,14 +64,14 @@ async def _async_create_entry(self) -> FlowResult:
             CONF_PASSWORD: self._hub._data[CONF_PASSWORD],
         }
 
+        await self._hub.disconnect()
         if existing_entry:
             self.hass.config_entries.async_update_entry(
                 existing_entry, data=config_data
             )
             await self.hass.config_entries.async_reload(existing_entry.entry_id)
             return self.async_abort(reason="reauth_successful")
 
-        await self._hub.disconnect()
         return self.async_create_entry(
             title=config_data[CONF_USERNAME], data=config_data
         )
@@ -143,7 +143,7 @@ async def async_step_reauth(
         self, user_input: dict[str, Any] | None = None
     ) -> FlowResult:
         """Perform reauth upon an API authentication error."""
-        return await self.async_step_reauth_confirm()
+        return await self.async_step_reauth_confirm(user_input)
 
     async def async_step_reauth_confirm(
         self, user_input: dict[str, Any] | None = None

diff --git a/custom_components/vivint/manifest.json b/custom_components/vivint/manifest.json
@@ -1,17 +1,11 @@
 {
   "domain": "vivint",
   "name": "Vivint",
-  "version": "2022.4.0",
+  "version": "2022.5.0",
   "config_flow": true,
   "documentation": "https://github.com/natekspencer/hacs-vivint",
   "issue_tracker": "https://github.com/natekspencer/hacs-vivint/issues",
-  "requirements": [
-    "vivintpy==2022.1.0"
-  ],
-  "dependencies": [
-    "ffmpeg"
-  ],
-  "codeowners": [
-    "@natekspencer"
-  ]
-}
+  "requirements": ["vivintpy==2022.1.0"],
+  "dependencies": ["ffmpeg"],
+  "codeowners": ["@natekspencer"]
+}
diff --git a/custom_components/vivint/sensor.py b/custom_components/vivint/sensor.py
@@ -67,7 +67,7 @@ class VivintBatterySensorEntity(VivintEntity, SensorEntity):
 
     _attr_device_class = SensorDeviceClass.BATTERY
     _attr_entity_category = EntityCategory.DIAGNOSTIC
-    _attr_unit_of_measurement = PERCENTAGE
+    _attr_native_unit_of_measurement = PERCENTAGE
 
     @property
     def name(self) -> str: