-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add notebook for CEO meta analysis #276
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
2/20/23 meeting notes
Notes:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great start Ben, thanks for pushing this forward!
I've added lot's of comments, many of them are of the "clean code" variety which can be subjective, so feel free to disagree! On the whole I think meta_utils.py can be shortened down a bit by cleaning comments and simplifying. I also don't know if I am convinced by this meta
prefix, I feel disagreement
or consensus
may be more appropriate. Let me know your thoughts!
@bhyeh let me know when this is ready for a second look! |
flake8 has some issues with the |
This is looking pretty good, any thoughts about some of the notebook comments? I am happy to merge soon and iterate if need be. |
Thanks! Yes I do plan on making further changes on the notebook - waiting for some feedback from Hannah and will then address your comments there as well. |
@bhyeh can this be merged in the near term (after pre-commit issues are addressed)? |
I think I need to touch base w/ @hannah-rae for her thoughts. I'll bring this up again with our 1:1 this Monday. |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Notebook for generating simple meta insights to CEO labeling project.
Remaining items and thoughts: