Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Stacked Plot] fix initial drop into plot not editable #7990

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

johnriedel
Copy link
Contributor

@johnriedel johnriedel commented Jan 17, 2025

Closes #7865

Describe your changes:

Upon initial drop into a stacked plot, the edit status of the openmct editor was properly retrieved. However this retrieved status wasn't passed to the setEditState() function in plugins/plot/stackedPlot/StackedPlotItem.vue for handling. This resulted in the newly dropped item from being edited, even though the editor was in edit mode. This fix passes the initial value to its handler resulting in an editable item upon initial drop into a stacked plot.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this a notable change that will require a special callout in the release notes? For example, will this break compatibility with existing APIs or projects that consume these plugins?

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Has this been smoke tested?
  • Have you associated this PR with a type: label? Note: this is not necessarily the same as the original issue.
  • Have you associated a milestone with this PR? Note: leave blank if unsure.
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?

Testing Instructions

  1. Create a stacked plot and save it
  2. Drag and Drop an item into the stacked plot which will put it into edit mode
  3. Try to select the item to edit it's properties. The item should successfully be selectable.

Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.58%. Comparing base (5be103e) to head (adc1ca7).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7990      +/-   ##
==========================================
- Coverage   57.70%   57.58%   -0.12%     
==========================================
  Files         678      678              
  Lines       27428    27429       +1     
  Branches     2691     2691              
==========================================
- Hits        15826    15796      -30     
- Misses      11264    11291      +27     
- Partials      338      342       +4     
Flag Coverage Δ
e2e-ci 62.82% <ø> (+<0.01%) ⬆️
e2e-full 41.95% <ø> (-0.06%) ⬇️
unit 49.34% <100.00%> (-0.18%) ⬇️
Files with missing lines Coverage Δ
src/plugins/plot/stackedPlot/StackedPlotItem.vue 39.70% <100.00%> (+2.39%) ⬆️

... and 12 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5be103e...adc1ca7. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Stacked Plots] Items unable to be selected on initial drop into stacked plot
1 participant