Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MctPlot, Overlay] add suppression option to overlay dialog #7989

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

johnriedel
Copy link
Contributor

Closes #7927

Describe your changes:

This feature adds a suppression option to overlays (defaults to no suppression option visible).
image

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this a notable change that will require a special callout in the release notes? For example, will this break compatibility with existing APIs or projects that consume these plugins?

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Has this been smoke tested?
  • Have you associated this PR with a type: label? Note: this is not necessarily the same as the original issue.
  • Have you associated a milestone with this PR? Note: leave blank if unsure.
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?

Testing Instructions

  1. Add a plot or sine wave generator to your items.
  2. Adjust the zoom level of the plot and click the "Synchronize Time Conductor" clock icon in the upper left corner of the plot.
  3. A pop-up "Synchronize Time Conductor" modal will appear. Notice a "Don't ask again" checkbox option in the lower left corner of the pop-up modal. Put a checkmark in the box and click Ok.
  4. Repeat steps 1 and 2. The pop-up modal should no longer appear.

Copy link

codecov bot commented Jan 16, 2025

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 57.27%. Comparing base (5be103e) to head (3d3bae2).

Files with missing lines Patch % Lines
src/plugins/plot/MctPlot.vue 0.00% 5 Missing ⚠️
src/api/overlays/components/OverlayComponent.vue 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7989      +/-   ##
==========================================
- Coverage   57.70%   57.27%   -0.43%     
==========================================
  Files         678      678              
  Lines       27428    27433       +5     
  Branches     2691     2692       +1     
==========================================
- Hits        15826    15712     -114     
- Misses      11264    11380     +116     
- Partials      338      341       +3     
Flag Coverage Δ
e2e-ci 62.82% <ø> (+<0.01%) ⬆️
e2e-full 23.65% <ø> (-18.36%) ⬇️
unit 49.30% <0.00%> (-0.23%) ⬇️
Files with missing lines Coverage Δ
src/api/overlays/Overlay.js 94.44% <ø> (ø)
src/api/overlays/components/OverlayComponent.vue 71.42% <0.00%> (-3.58%) ⬇️
src/plugins/plot/MctPlot.vue 36.99% <0.00%> (-0.21%) ⬇️

... and 17 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5be103e...3d3bae2. Read the comment docs.

@johnriedel johnriedel force-pushed the 7927-add-overlay-dialog-suppression-option branch 5 times, most recently from ddf73cc to 3d3bae2 Compare January 17, 2025 02:36
</div>
<div v-if="buttons" class="c-overlay__button-bar">
<button
v-for="(button, index) in buttons"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

buttonIndex to make the section explicit and readable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Time Conductor] Flag to not be prompted when synchronizing Time Conductor
2 participants