Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Snapshot] fix #7941 for faulty snapshot 3-dot menu sizing #7988

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

johnriedel
Copy link
Contributor

Closes #7941

Describe your changes:

Modified CSS to prevent snapshot 3-dot menu from collapsing horizontally making the menu options unreadable.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this a notable change that will require a special callout in the release notes? For example, will this break compatibility with existing APIs or projects that consume these plugins?

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Has this been smoke tested?
  • Have you associated this PR with a type: label? Note: this is not necessarily the same as the original issue.
  • Have you associated a milestone with this PR? Note: leave blank if unsure.
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?

Testing Instructions

  1. Take a snapshot and save it to snapshots, not a notebook
  2. Expand the snapshot drawer from the snapshots icon in the notifications area
  3. Click the three dot menu in a snapshot
  4. The Title items on the left side of menu should not be cut off by the 3-dot menu width.
  5. Shrink the viewport (browser screen) vertically; the 3-dot menu will not shrink horizontally and cut-off the tile item text.

@johnriedel johnriedel force-pushed the 7941-snapshot-three-dot-menu-sizing branch from 6e20e83 to 4ecbe44 Compare January 16, 2025 01:48
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.26%. Comparing base (5be103e) to head (4ecbe44).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7988      +/-   ##
==========================================
- Coverage   57.70%   57.26%   -0.44%     
==========================================
  Files         678      678              
  Lines       27428    27428              
  Branches     2691     2691              
==========================================
- Hits        15826    15708     -118     
- Misses      11264    11378     +114     
- Partials      338      342       +4     
Flag Coverage Δ
e2e-ci 62.82% <ø> (ø)
e2e-full 23.65% <ø> (-18.36%) ⬇️
unit 49.30% <ø> (-0.22%) ⬇️

see 16 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5be103e...4ecbe44. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Titles in snapshot 3 dot menu are cut off
1 participant