Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gantt chart swimlane order #7895

Merged
merged 3 commits into from
Oct 17, 2024
Merged

Conversation

shefalijoshi
Copy link
Contributor

@shefalijoshi shefalijoshi commented Oct 16, 2024

Closes VIPERGC-652

Describe your changes:

Since the plan view is used by both objects of type plan and gantt chart, use the plan object to get swim lane order.
This will ensure that both views work correctly.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this a notable change that will require a special callout in the release notes? For example, will this break compatibility with existing APIs or projects that consume these plugins?

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Has this been smoke tested?
  • Have you associated this PR with a type: label? Note: this is not necessarily the same as the original issue.
  • Have you associated a milestone with this PR? Note: leave blank if unsure.
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?

Copy link

codecov bot commented Oct 16, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 57.43%. Comparing base (7c2bb16) to head (b9eef3b).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/plugins/plan/components/PlanView.vue 25.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7895      +/-   ##
==========================================
- Coverage   62.54%   57.43%   -5.12%     
==========================================
  Files         434      676     +242     
  Lines       13592    27355   +13763     
  Branches        0     2685    +2685     
==========================================
+ Hits         8501    15710    +7209     
- Misses       5091    11308    +6217     
- Partials        0      337     +337     
Flag Coverage Δ
e2e-ci 62.47% <ø> (+0.01%) ⬆️
e2e-full 41.78% <ø> (+18.31%) ⬆️
unit 49.30% <25.00%> (?)
Files with missing lines Coverage Δ
src/plugins/plan/components/PlanView.vue 59.32% <25.00%> (ø)

... and 371 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c2bb16...b9eef3b. Read the comment docs.

Copy link
Contributor

@jvigliotta jvigliotta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@jvigliotta jvigliotta added the pr:e2e:couchdb npm run test:e2e:couchdb label Oct 17, 2024
@jvigliotta jvigliotta enabled auto-merge (squash) October 17, 2024 16:26
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Oct 17, 2024
@jvigliotta jvigliotta added this to the Build 9 RC11 milestone Oct 17, 2024
@jvigliotta jvigliotta merged commit 7f8b5e0 into master Oct 17, 2024
37 of 44 checks passed
@jvigliotta jvigliotta deleted the fix-gantt-chart-swimlane-order branch October 17, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants