fix(vipergc-574): Use selected shelve duration for fault management

[ozyx]

Closes VIPERGC-574
Closes #7853

Describe your changes:

• Fixes faulty logic which was preventing the selected shelve duration from being used in the request to the fault provider
• Renames default shelve duration from 'Indefinite' to 'Unlimited'
• Removes an unused const

All Submissions:

• Have you followed the guidelines in our Contributing document?
• Have you checked to ensure there aren't other open Pull Requests for the same update/change?
• Is this a notable change that will require a special callout in the release notes? For example, will this break compatibility with existing APIs or projects that consume these plugins?

Author Checklist

• Changes address original issue?
• Tests included and/or updated with changes?
• Has this been smoke tested?
• Have you associated this PR with a type: label? Note: this is not necessarily the same as the original issue.
• Have you associated a milestone with this PR? Note: leave blank if unsure.
• Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

• Changes appear to address issue?
• Reviewer has tested changes by following the provided instructions?
• Changes appear not to be breaking changes?
• Appropriate automated tests included?
• Code style and in-line documentation are appropriate?

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.97%. Comparing base (2b86739) to head (6b2abd0).
Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #7890      +/-   ##
==========================================
+ Coverage   57.61%   64.97%   +7.36%     
==========================================
  Files         676      434     -242     
  Lines       27351    13592   -13759     
  Branches     2685        0    -2685     
==========================================
- Hits        15759     8832    -6927     
+ Misses      11257     4760    -6497     
+ Partials      335        0     -335     

Flag	Coverage Δ
e2e-ci	62.44% <100.00%> (+<0.01%)	⬆️
e2e-full	41.81% <0.00%> (-12.21%)	⬇️
unit	?

Files with missing lines	Coverage Δ
src/api/faultmanagement/FaultManagementAPI.js	93.33% <100.00%> (+1.02%)	⬆️
src/plugins/faultManagement/constants.js	70.37% <ø> (-11.78%)	⬇️

... and 369 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b86739...6b2abd0. Read the comment docs.

[jvigliotta]

ah, nice catch

[jvigliotta]

Nice work! Tested locally, looking good.