Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Telemetry Tables] Fix sort issues #7875

Merged
merged 12 commits into from
Oct 10, 2024
Merged

[Telemetry Tables] Fix sort issues #7875

merged 12 commits into from
Oct 10, 2024

Conversation

jvigliotta
Copy link
Contributor

@jvigliotta jvigliotta commented Oct 9, 2024

Closes #7809

Describe your changes:

There was an issue where immutable objects sort order was not being set correctly in telemetry tables. This is because their configuration couldn't be saved and the sort order was not being saved in memory. There was another issue where telemetry was not being re-requested when the sort order of a table was changed and the table was in performance (limited) mode. This would result in incorrect data.

We've moved sort order to both configuration and in-memory and we will re-request telemetry if changing sort order in performance mode.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this a notable change that will require a special callout in the release notes? For example, will this break compatibility with existing APIs or projects that consume these plugins?

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes? Test for sort fixes #7876
  • Has this been smoke tested?
  • Have you associated this PR with a type: label? Note: this is not necessarily the same as the original issue.
  • Have you associated a milestone with this PR? Note: leave blank if unsure.
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?

@jvigliotta jvigliotta added this to the Build 9 RC11 milestone Oct 9, 2024
@jvigliotta jvigliotta mentioned this pull request Oct 9, 2024
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

Attention: Patch coverage is 93.75000% with 1 line in your changes missing coverage. Please review.

Project coverage is 57.54%. Comparing base (f4cf9c7) to head (66bc767).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/plugins/telemetryTable/TelemetryTable.js 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7875      +/-   ##
==========================================
+ Coverage   57.13%   57.54%   +0.40%     
==========================================
  Files         676      676              
  Lines       27320    27326       +6     
  Branches     2673     2673              
==========================================
+ Hits        15610    15725     +115     
+ Misses      11374    11267     -107     
+ Partials      336      334       -2     
Flag Coverage Δ
e2e-ci 62.46% <93.75%> (+0.08%) ⬆️
e2e-full 41.79% <0.00%> (+18.31%) ⬆️
unit 49.44% <37.50%> (+0.12%) ⬆️
Files with missing lines Coverage Δ
...gins/telemetryTable/TelemetryTableConfiguration.js 66.27% <100.00%> (+2.52%) ⬆️
...s/telemetryTable/collections/TableRowCollection.js 63.51% <100.00%> (-0.44%) ⬇️
src/plugins/telemetryTable/TelemetryTable.js 84.31% <87.50%> (+1.38%) ⬆️

... and 14 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4cf9c7...66bc767. Read the comment docs.

@jvigliotta jvigliotta added the pr:e2e:couchdb npm run test:e2e:couchdb label Oct 9, 2024
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Oct 9, 2024
@jvigliotta jvigliotta requested review from ozyx and akhenry October 10, 2024 17:42
Copy link
Contributor

@ozyx ozyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple minor suggestions

src/plugins/telemetryTable/TelemetryTable.js Outdated Show resolved Hide resolved
src/plugins/telemetryTable/TelemetryTable.js Outdated Show resolved Hide resolved
Copy link
Contributor

@ozyx ozyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ship it

src/plugins/telemetryTable/TelemetryTable.js Outdated Show resolved Hide resolved
Copy link
Contributor

@akhenry akhenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made changes suggested in review and pushed.

@akhenry akhenry added the pr:e2e:couchdb npm run test:e2e:couchdb label Oct 10, 2024
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Oct 10, 2024
@akhenry akhenry added the pr:e2e:couchdb npm run test:e2e:couchdb label Oct 10, 2024
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Oct 10, 2024
@akhenry akhenry merged commit c43ef64 into master Oct 10, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Telemetry TABLES!] Changing performance mode changes sort order of request unexpectedly
3 participants