-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Telemetry Tables] Fix sort issues #7875
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7875 +/- ##
==========================================
+ Coverage 57.13% 57.54% +0.40%
==========================================
Files 676 676
Lines 27320 27326 +6
Branches 2673 2673
==========================================
+ Hits 15610 15725 +115
+ Misses 11374 11267 -107
+ Partials 336 334 -2
... and 14 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple minor suggestions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ship it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made changes suggested in review and pushed.
Closes #7809
Describe your changes:
There was an issue where immutable objects sort order was not being set correctly in telemetry tables. This is because their configuration couldn't be saved and the sort order was not being saved in memory. There was another issue where telemetry was not being re-requested when the sort order of a table was changed and the table was in performance (limited) mode. This would result in incorrect data.
We've moved sort order to both configuration and in-memory and we will re-request telemetry if changing sort order in performance mode.
All Submissions:
Author Checklist
type:
label? Note: this is not necessarily the same as the original issue.Reviewer Checklist