-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix complex displays not loading #7858
Conversation
temporarily enable eval-source-maps
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7858 +/- ##
==========================================
+ Coverage 57.14% 64.91% +7.77%
==========================================
Files 675 433 -242
Lines 27317 13583 -13734
Branches 2673 0 -2673
==========================================
- Hits 15611 8818 -6793
+ Misses 11370 4765 -6605
+ Partials 336 0 -336
... and 366 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
- Modded CSS to use more performant `transform` animation rather than `width` for the indeterminate progress bar. Standard progress still uses a set width.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just a few suggestions
@akhenry , ready to review again. calling |
Gotcha, works for me, thanks! |
Reviewer out and unable to approve. Can address in followup if there are any issues remaining.
Closes #7857
Describe your changes:
1.1 pass in default timeContext in request options
1.3 observe for clock tick, instead of polling, to determine if clock has time set
2.1 use scale instead of move animation
3.1 use a
ResizeObserver
instead of polling for size changesAll Submissions:
Author Checklist
#7857
#7860type:
label? Note: this is not necessarily the same as the original issue.Reviewer Checklist