Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix complex displays not loading #7858

Merged
merged 23 commits into from
Oct 8, 2024
Merged

Fix complex displays not loading #7858

merged 23 commits into from
Oct 8, 2024

Conversation

davetsay
Copy link
Contributor

@davetsay davetsay commented Oct 1, 2024

Closes #7857

Describe your changes:

  1. Clock
    1.1 pass in default timeContext in request options
    1.3 observe for clock tick, instead of polling, to determine if clock has time set
  2. Progress Bars
    2.1 use scale instead of move animation
  3. Plan
    3.1 use a ResizeObserver instead of polling for size changes

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this a notable change that will require a special callout in the release notes? For example, will this break compatibility with existing APIs or projects that consume these plugins?

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes? Write e2e test for #7857 #7860
  • Has this been smoke tested?
  • Have you associated this PR with a type: label? Note: this is not necessarily the same as the original issue.
  • Have you associated a milestone with this PR? Note: leave blank if unsure.
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?

Copy link

codecov bot commented Oct 1, 2024

Codecov Report

Attention: Patch coverage is 57.89474% with 8 lines in your changes missing coverage. Please review.

Project coverage is 64.91%. Comparing base (83e4a12) to head (6269ecc).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/plugins/remoteClock/RemoteClock.js 0.00% 6 Missing ⚠️
src/plugins/remoteClock/requestInterceptor.js 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7858      +/-   ##
==========================================
+ Coverage   57.14%   64.91%   +7.77%     
==========================================
  Files         675      433     -242     
  Lines       27317    13583   -13734     
  Branches     2673        0    -2673     
==========================================
- Hits        15611     8818    -6793     
+ Misses      11370     4765    -6605     
+ Partials      336        0     -336     
Flag Coverage Δ
e2e-ci 62.38% <57.89%> (-0.02%) ⬇️
e2e-full 41.86% <52.63%> (+18.36%) ⬆️
unit ?
Files with missing lines Coverage Δ
src/api/telemetry/TelemetryAPI.js 80.49% <100.00%> (-8.89%) ⬇️
src/api/telemetry/TelemetryCollection.js 80.40% <100.00%> (-8.05%) ⬇️
src/plugins/remoteClock/requestInterceptor.js 0.00% <0.00%> (-18.19%) ⬇️
src/plugins/remoteClock/RemoteClock.js 0.00% <0.00%> (-84.79%) ⬇️

... and 366 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83e4a12...6269ecc. Read the comment docs.

charlesh88 and others added 5 commits September 30, 2024 17:22
- Modded CSS to use more performant `transform` animation rather than `width` for the indeterminate progress bar. Standard progress still uses a set width.
@davetsay davetsay marked this pull request as ready for review October 2, 2024 16:22
@davetsay davetsay added this to the Target:4.1.0 milestone Oct 2, 2024
@davetsay davetsay added type:bug bug:regression It used to work. Now it doesn't :( performance impacts or improves performance build9-rc11 labels Oct 2, 2024
@ozyx ozyx self-requested a review October 2, 2024 17:25
ozyx
ozyx previously requested changes Oct 2, 2024
Copy link
Contributor

@ozyx ozyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a few suggestions

src/plugins/plan/components/PlanView.vue Show resolved Hide resolved
src/plugins/remoteClock/requestInterceptor.js Outdated Show resolved Hide resolved
src/ui/components/progress-bar.scss Show resolved Hide resolved
@davetsay davetsay requested a review from ozyx October 2, 2024 20:36
src/api/telemetry/TelemetryAPI.js Outdated Show resolved Hide resolved
src/plugins/remoteClock/RemoteClock.js Show resolved Hide resolved
src/plugins/remoteClock/requestInterceptor.js Outdated Show resolved Hide resolved
@davetsay davetsay added pr:e2e Automatically triggers e2e tests to run and removed pr:e2e Automatically triggers e2e tests to run labels Oct 3, 2024
@davetsay davetsay requested a review from akhenry October 3, 2024 21:27
@davetsay davetsay requested a review from akhenry October 8, 2024 18:06
@davetsay davetsay added pr:e2e Automatically triggers e2e tests to run and removed pr:e2e Automatically triggers e2e tests to run labels Oct 8, 2024
@davetsay
Copy link
Contributor Author

davetsay commented Oct 8, 2024

@akhenry , ready to review again. calling standardizeRequestOptions in load breaks tests. I think its setting of option bounds too early, is then conflicting with what should be sent in a request on a time conductor and indepedent time conductor bounds change.

@akhenry
Copy link
Contributor

akhenry commented Oct 8, 2024

@akhenry , ready to review again. calling standardizeRequestOptions in load breaks tests. I think its setting of option bounds too early, is then conflicting with what should be sent in a request on a time conductor and indepedent time conductor bounds change.

Gotcha, works for me, thanks!

@akhenry akhenry added the pr:e2e:couchdb npm run test:e2e:couchdb label Oct 8, 2024
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Oct 8, 2024
@akhenry akhenry dismissed ozyx’s stale review October 8, 2024 20:09

Reviewer out and unable to approve. Can address in followup if there are any issues remaining.

@akhenry akhenry merged commit 4415fe7 into master Oct 8, 2024
29 checks passed
@akhenry akhenry deleted the vipergc-415 branch October 8, 2024 20:10
@unlikelyzero unlikelyzero added the notable_change A change which should be noted in the changelog label Oct 9, 2024
davetsay added a commit that referenced this pull request Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug:regression It used to work. Now it doesn't :( build9-rc11 notable_change A change which should be noted in the changelog performance impacts or improves performance type:bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display became inoperable
5 participants