Handle paste events for images and text properly #7679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
better event handling
|
Code is ready and smoke tested, @akhenry . Just gonna write up some tests |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7679 +/- ##
==========================================
- Coverage 56.63% 56.29% -0.34%
==========================================
Files 672 672
Lines 27124 27135 +11
Branches 2632 2634 +2
==========================================
- Hits 15361 15276 -85
- Misses 11436 11531 +95
- Partials 327 328 +1
... and 10 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
add clipboard functions
ozyx
suggested changes
Apr 16, 2024
| @@ -27,6 +27,7 @@ This test suite is dedicated to tests which verify the basic operations surround | |||
| import { fileURLToPath } from 'url'; | |||
|
|
|||
| import { createDomainObjectWithDefaults } from '../../../../appActions.js'; | |||
| import hotkeys from '../../../../helper/hotkeys/hotkeys.js'; | |||
There was a problem hiding this comment.
Suggested change
| import hotkeys from '../../../../helper/hotkeys/hotkeys.js'; | |
| import { copy, paste, selectAll } from '../../../../helper/hotkeys/hotkeys.js'; |
Comment on lines
567
to
568
| await hotkeys.selectAll(page); | ||
| await hotkeys.copy(page); |
There was a problem hiding this comment.
Suggested change
| await hotkeys.selectAll(page); | |
| await hotkeys.copy(page); | |
| await selectAll(page); | |
| await copy(page); |
etc
Comment on lines
+596
to
+597
| await expect(await page.locator(`text="${TEST_TEXT.repeat(1)}"`).count()).toEqual(1); | ||
| await expect(await page.locator(`text="${TEST_TEXT.repeat(2)}"`).count()).toEqual(0); |
There was a problem hiding this comment.
Suggested change
| await expect(await page.locator(`text="${TEST_TEXT.repeat(1)}"`).count()).toEqual(1); | |
| await expect(await page.locator(`text="${TEST_TEXT.repeat(2)}"`).count()).toEqual(0); | |
| expect(await page.locator(`text="${TEST_TEXT.repeat(1)}"`).count()).toEqual(1); | |
| expect(await page.locator(`text="${TEST_TEXT.repeat(2)}"`).count()).toEqual(0); |
| // If the clipboard contained an image, prevent the paste event from reaching the textarea. | ||
| if (hasImage) { | ||
| addTextFromPaste(event) { | ||
| if (!this.editMode) { |
There was a problem hiding this comment.
This is easily confused for the API's Edit mode. Can we rename this to make it clear that it refers to the notebook entry being editable?
Co-authored-by: Jesse Mazzella <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7686
Describe your changes:
paste text outside text area: no-oppaste text inside text area (editing): default paste event behaviorpaste image outside text area: image attachedpaste image inside text area (editing): image attached (FEATURE, DEFINITELY NOT A BUG: this persists the notebook entry, including any text edits made prior to the image paste, and leaves the entry in edit mode. If you want the entry to be committed on image paste, not in edit mode, or something else entirely, let me know @charlesh88 )All Submissions:
Author Checklist
type:label? Note: this is not necessarily the same as the original issue.Reviewer Checklist