Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: ensure legacy indicators align with Vue indicators #7458

Merged
merged 4 commits into from
Feb 15, 2024
Merged

Conversation

ozyx
Copy link
Contributor

@ozyx ozyx commented Feb 3, 2024

Closes #7457

Describe your changes:

Adds width='100%' and height='100%' to main legacy indicator elements before wrapping them in a Vue component so they fill the entire wrapper space and display correctly.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Has this been smoke tested?
  • Have you associated this PR with a type: label? Note: this is not necessarily the same as the original issue.
  • Have you associated a milestone with this PR? Note: leave blank if unsure.
  • Is this a breaking change to be called out in the release notes?
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?

@ozyx ozyx added type:bug bug:visual Visual problem. Not a functional issue labels Feb 3, 2024
@ozyx ozyx added this to the Target:4.0.0 milestone Feb 3, 2024
@ozyx ozyx requested review from charlesh88 and scottbell February 3, 2024 00:47
Copy link

codecov bot commented Feb 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4fbccd4) 55.36% compared to head (cb75942) 55.51%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7458      +/-   ##
==========================================
+ Coverage   55.36%   55.51%   +0.15%     
==========================================
  Files         671      671              
  Lines       27010    27010              
  Branches     2631     2631              
==========================================
+ Hits        14954    14995      +41     
+ Misses      11333    11292      -41     
  Partials      723      723              
Flag Coverage Δ
e2e-full 48.91% <ø> (+7.78%) ⬆️
e2e-stable 59.38% <100.00%> (+0.17%) ⬆️
unit 48.44% <100.00%> (ø)
Files Coverage Δ
src/utils/vueWrapHtmlElement.js 100.00% <100.00%> (ø)

... and 9 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4fbccd4...cb75942. Read the comment docs.

@ozyx ozyx requested a review from rukmini-bose February 14, 2024 17:06
@charlesh88
Copy link
Contributor

Per discussion, it'd be better to apply the CSS class u-contents (which is just display: contents) to the Vue wrapper when it's holding a legacy component. This will remove the Vue element wrapper as a considered element in the browser's rendering flow.

Copy link
Contributor

@charlesh88 charlesh88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice.

@ozyx ozyx added the pr:e2e:couchdb npm run test:e2e:couchdb label Feb 15, 2024
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Feb 15, 2024
Copy link
Contributor

@scottbell scottbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice!
Screenshot 2024-02-15 at 8 21 35 PM

@scottbell scottbell merged commit 847232d into master Feb 15, 2024
27 of 33 checks passed
@scottbell scottbell deleted the mct7457 branch February 15, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug:visual Visual problem. Not a functional issue type:bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HTMLElement indicators are not justified with Vue indicators in the status bar
3 participants