-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
style: ensure legacy indicators align with Vue indicators #7458
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7458 +/- ##
==========================================
+ Coverage 55.36% 55.51% +0.15%
==========================================
Files 671 671
Lines 27010 27010
Branches 2631 2631
==========================================
+ Hits 14954 14995 +41
+ Misses 11333 11292 -41
Partials 723 723
... and 9 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Per discussion, it'd be better to apply the CSS class |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Nice.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Closes #7457
Describe your changes:
Adds
width='100%'
andheight='100%'
to main legacy indicator elements before wrapping them in a Vue component so they fill the entire wrapper space and display correctly.All Submissions:
Author Checklist
type:
label? Note: this is not necessarily the same as the original issue.Reviewer Checklist