Merge remote-tracking branch 'origin/telemetry-comps' into combined-r…

…odap-stuff
nasa · Oct 28, 2024 · f19d7a8 · f19d7a8
2 parents dc13592 + 55063a0
commit f19d7a8
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 25 deletions.
diff --git a/e2e/tests/functional/plugins/comps/comps.e2e.spec.js b/e2e/tests/functional/plugins/comps/comps.e2e.spec.js
@@ -27,6 +27,7 @@ import {
 import { expect, test } from '../../../../pluginFixtures.js';
 
 test.describe('Comps', () => {
+  test.use({ failOnConsoleError: false });
   test.beforeEach(async ({ page }) => {
     // Open a browser, navigate to the main page, and wait until all networkevents to resolve
     await page.goto('./', { waitUntil: 'domcontentloaded' });

diff --git a/src/plugins/comps/CompsManager.js b/src/plugins/comps/CompsManager.js
@@ -115,10 +115,6 @@ export default class CompsManager extends EventEmitter {
     const loadVersion = ++this.#loadVersion;
 
     if (!_.isEqual(this.#telemetryOptions, telemetryOptions)) {
-      console.debug(
-        `😩 Reloading comps manager ${this.#domainObject.name} due to telemetry options change.`,
-        telemetryOptions
-      );
       this.#destroy();
     }
 
@@ -131,9 +127,6 @@ export default class CompsManager extends EventEmitter {
         await this.#loadComposition();
         // Check if a newer load has been initiated
         if (loadVersion !== this.#loadVersion) {
-          console.debug(
-            `🔄 Reloading comps manager in composition wait ${this.#domainObject.name} due to newer load.`
-          );
           await this.#currentLoadPromise;
           return;
         }
@@ -145,16 +138,9 @@ export default class CompsManager extends EventEmitter {
         await this.#startListeningToUnderlyingTelemetry();
         // Check again for newer load
         if (loadVersion !== this.#loadVersion) {
-          console.debug(
-            `🔄 Reloading comps manager in telemetry wait ${this.#domainObject.name} due to newer load.`
-          );
           await this.#currentLoadPromise;
           return;
         }
-        console.debug(
-          `✅ Comps manager ${this.#domainObject.name} is ready.`,
-          this.#telemetryCollections
-        );
         this.#loaded = true;
       }
     })();
@@ -259,8 +245,6 @@ export default class CompsManager extends EventEmitter {
         const imputedDatum = this.#getImputedDataUsingLOCF(fakeData, telemetryCollection);
         if (imputedDatum) {
           alignedValues.push(imputedDatum);
-        } else {
-          console.debug(`🚨 Missing data for ${keyString} at ${timestamp}`);
         }
       });
 

diff --git a/src/plugins/comps/CompsTelemetryProvider.js b/src/plugins/comps/CompsTelemetryProvider.js
@@ -80,11 +80,6 @@ export default class CompsTelemetryProvider {
           parameters,
           callbackID
         };
-        console.debug(
-          `📝 Requesting calculation for ${domainObject.name} with callback ID ${callbackID}:`,
-          options,
-          payload
-        );
         this.#sharedWorker.port.postMessage(payload);
       });
     });
@@ -130,9 +125,6 @@ export default class CompsTelemetryProvider {
       size: 1
     };
     specificCompsManager.load(telemetryOptions);
-    console.debug(
-      `📝 Starting subscription for ${domainObject.name} with callback ID ${callbackID}`
-    );
     return () => {
       delete this.#subscriptionCallbacks[callbackID];
       specificCompsManager.stopListeningToUnderlyingTelemetry();
@@ -171,7 +163,6 @@ export default class CompsTelemetryProvider {
         console.error('📝 Error calculating request:', event.data);
         this.#requestPromises[callbackID].resolve([]);
       } else {
-        console.debug(`🧮 Calculation request result for ${callbackID}:`, result);
         this.#requestPromises[callbackID].resolve(result);
       }
       delete this.#requestPromises[callbackID];