-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CUMULUS-3960: Updated PostToCmr task to be able to republish granules #3906
base: master
Are you sure you want to change the base?
Conversation
.eslintrc.js
Outdated
@@ -62,6 +62,7 @@ module.exports = { | |||
}, | |||
globals: { | |||
JSX: true, | |||
AggregateError: false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is to resolve eslint error error 'AggregateError' is not defined
. Later versions of eslint have resolved the error.
const results = await pMap( | ||
updatedCMRFiles, | ||
(cmrFile) => publish2CMR(cmrFile, cmrSettings, cmrRevisionId), | ||
{ concurrency } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
stopOnError: true
is default, if set to false
, it will change current lambda behavior
@@ -5,6 +5,6 @@ | |||
], | |||
"statements": 94.0, | |||
"functions": 88.0, | |||
"branches": 97.0, | |||
"branches": 88.0, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only the handler function is not covered as before, not sure how to improve this.
…o jl/CUMULUS-3960
Summary: Summary of changes
Addresses CUMULUS-3960: Update CMR metadata with new collection info
Changes
PostToCmr
task to be able torepublish
granulesTesting
Note: The cmr concept-id remains the same in my test
PR Checklist