CUMULUS-3959: Add documentation to resolve failing db migrations #3896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
npauzenga
requested changes
Jan 27, 2025
There was a problem hiding this comment.
This looks great @Nnaga1. I left a few suggestions, mainly just wording preference. Feel free to reject.
I'm partially trying to say a bit less about the VACUUM statements. It'll be very DAAC-dependent and these should be done manually/outside of deployment as a part of healthy data management. I think here the goal is to point out that they caused a problem and that the next patch release fixes that problem.
website/versioned_docs/version-v18.5.0/troubleshooting/troubleshoot_database_migration.md
Show resolved
Hide resolved
website/versioned_docs/version-v18.5.0/troubleshooting/troubleshoot_database_migration.md
Outdated
Show resolved
Hide resolved
website/versioned_docs/version-v18.5.0/troubleshooting/troubleshoot_database_migration.md
Outdated
Show resolved
Hide resolved
website/versioned_docs/version-v18.5.0/troubleshooting/troubleshoot_database_migration.md
Outdated
Show resolved
Hide resolved
website/versioned_docs/version-v18.5.0/troubleshooting/troubleshoot_database_migration.md
Outdated
Show resolved
Hide resolved
website/versioned_docs/version-v18.5.0/troubleshooting/troubleshoot_database_migration.md
Outdated
Show resolved
Hide resolved
website/versioned_docs/version-v18.5.0/troubleshooting/troubleshoot_database_migration.md
Outdated
Show resolved
Hide resolved
website/versioned_docs/version-v18.5.0/troubleshooting/troubleshoot_database_migration.md
Outdated
Show resolved
Hide resolved
website/versioned_docs/version-v18.5.0/troubleshooting/troubleshoot_database_migration.md
Outdated
Show resolved
Hide resolved
npauzenga
reviewed
Jan 28, 2025
|
|
||
| ### Other potential issues | ||
|
|
||
| Migration Lambda timeouts (or other related timeouts) may be caused by `VACUUM` statements in the migration. If you find your deployment not completing despite the migration table and the migrations being consistent, this may be the issue. In v18.5.2, some `VACUUM` statements have been removed to tailor for this issue. If you find yourself struggling with v18.5.1 despite completing the above steps, plese upgrade to v18.5.2 and try for this issue. If you find yourself struggling with v18.5.1 despite completing the above steps, plese upgrade to v18.5.2 and try deployment again. The removal of potentially long-running migrations may resolve the issue. |
There was a problem hiding this comment.
Suggested change
| Migration Lambda timeouts (or other related timeouts) may be caused by `VACUUM` statements in the migration. If you find your deployment not completing despite the migration table and the migrations being consistent, this may be the issue. In v18.5.2, some `VACUUM` statements have been removed to tailor for this issue. If you find yourself struggling with v18.5.1 despite completing the above steps, plese upgrade to v18.5.2 and try for this issue. If you find yourself struggling with v18.5.1 despite completing the above steps, plese upgrade to v18.5.2 and try deployment again. The removal of potentially long-running migrations may resolve the issue. | |
| Migration Lambda timeouts (or other related timeouts) may be caused by `VACUUM` statements in the migration. If you find your deployment not completing despite the migration table and the migrations being consistent, this may be the issue. In v18.5.2, some `VACUUM` statements have been removed to tailor for this issue. If you find yourself struggling with v18.5.1 despite completing the above steps, please upgrade to v18.5.2 and try deployment again. The removal of potentially long-running migrations may resolve the issue. |
There was a problem hiding this comment.
I think this was a bad merge
npauzenga
requested changes
Jan 28, 2025
…nto CUMULUS-3959-docs
npauzenga
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Summary of changes
Addresses CUMULUS-XX: Develop amazing new feature
Changes
PR Checklist