Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WV-2392-Add-VIIRS-SNPP-NOAA20-C2-L1-STD-layers #4549

Closed

Conversation

github-actions[bot]
Copy link

@github-actions github-actions bot commented Aug 4, 2023

Description

Fixes #

[Ids of the layers being added]

  • Included layer(s) were added to the `layer-order.json`
  • Included layer(s) have an appropriate `layergroup` defined
  • Included layer(s) were added the appropriate measurements
  • Included layer(s) have a corresponding preview image
  • Included layer(s) have the necessary visualization metadata configs in GIBS
  • The corresponding concept ids in the visualization metadata configs are valid and return a collection when requested from CMR (e.g. `https://cmr.earthdata.nasa.gov/search/concepts/.html`)

How To Test

  • Do the dates show properly in the layer details both when viewed from the sidebar and in the layer description when browsing?
  • Do the dates in the description match with what appears available when adjusting the timeline?
  • Do the layers properly group with other layers in the same `layergroup`?
  • Do the layers show in the right category/measurement when browsing?
  • Do the preview images for the layers look right when searching in the product picker?
  • Does data download work properly (if concept id present)?

PR Submission Checklist

This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have added necessary documentation (if applicable)
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • Any dependent changes have been merged and published in downstream modules (if applicable)

@nasa-gibs/worldview

@github-actions github-actions bot added the layer For layer additions/changes label Aug 4, 2023
@minniewong minniewong changed the title Add/modify layers refs/heads/WV-2392-Add-VIIRS-SNPP-NOAA20-C2-L1-STD-layers WV-2392-Add-VIIRS-SNPP-NOAA20-C2-L1-STD-layers Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
layer For layer additions/changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants