Starts a container in the deployment phase, cleans up on sandbox end #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dakota002
force-pushed
the
FirstBranch
branch
from
b3923fd to
a418c0d
Compare
lpsinger
requested changes
Jan 17, 2025
runDocker.ts
Outdated
| 'path.logs=/var/log/ddb-local', | ||
| ], | ||
| HostConfig: { | ||
| Binds: [`${dataDir}:/home/dynamodblocal/data`], |
There was a problem hiding this comment.
Remove bind mount. There's no need to persist the data to the host filesystem.
There was a problem hiding this comment.
I realized i could just use the run function from docker, I have updated it in the latest commit. I still need to clean it up, but it should be behaving as expected.
dakota002
force-pushed
the
FirstBranch
branch
from
ac4e6c8 to
ada8247
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly adapted from https://github.com/nasa-gcn/architect-plugin-search
Important notes:
This needs to start in the deploy phase, so that the docker container gets started before the @tables pragma stuff starts trying to populate tables