feat: allow for tests to be run without Polars installed, unify exceptions more #1896
+99
−55
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CC @MarcoGorelli
Sending early to get feedback on the approaches used.
I went for:
pytest.importorskip()
if the whole test (or module) seemed to rely onpolars
.try/except ImportError:
for tests that partially rely onpolars
— figured it would be weird to have them reported as "skipped" when the other part passed.pytest.raises()
, with appending thepolars
exception whenpolars
constructor is used.Issue #1726