Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop PY3.7 support in napalm 5.0.0; add tests for PY3.12 #2021

Merged
merged 4 commits into from
Mar 21, 2024

Conversation

ktbyers
Copy link
Contributor

@ktbyers ktbyers commented Nov 15, 2023

No description provided.

@ktbyers
Copy link
Contributor Author

ktbyers commented Nov 15, 2023

On hold pending Juniper PyEZ bug fix for PY3.12 bug pinning ncclient.

@bewing
Copy link
Member

bewing commented Jan 31, 2024

Believe this is good to go with pyez 2.7.0

https://github.com/Juniper/py-junos-eznc/pull/1288/files#diff-4d7c51b1efe9043e44439a949dfd92e5827321b34082903477fd04876edb7552

@ktbyers
Copy link
Contributor Author

ktbyers commented Jan 31, 2024

Also updated repository settings to test PY3.12 (and not test PY3.7)

@ktbyers
Copy link
Contributor Author

ktbyers commented Jan 31, 2024

@bewing Do you want to approve and merge this (it doesn't like me doing it, since I created the PR).

@bewing
Copy link
Member

bewing commented Jan 31, 2024

Do we want to hold this and just rebase/merge right before a release? What does our cadence look like? Merging now would make it harder to do bugfix releases.

@ktbyers
Copy link
Contributor Author

ktbyers commented Jan 31, 2024

I am open to either way. I guess we can just limbo this one and then we can do one more 4.x.x release (if we need to).

Copy link
Member

@bewing bewing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@mirceaulinic mirceaulinic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 😄

@mirceaulinic mirceaulinic merged commit a45cf4d into develop Mar 21, 2024
12 checks passed
@mirceaulinic mirceaulinic deleted the napalm_py_versions2 branch March 21, 2024 10:34
@mirceaulinic mirceaulinic added this to the 5.0.0 milestone Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants