Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IOS get_bgp_neighbors same IP different VRF - Fix #1497 #1231 #1751

Merged
merged 4 commits into from
Mar 21, 2024
Merged

IOS get_bgp_neighbors same IP different VRF - Fix #1497 #1231 #1751

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7124ff7
Check for existing VRF + Neighbor in get_bgp_neighbors()
Sep 13, 2022
c583cdf
Skip existing check for non-VRF neighbors (multiple AFIs)
Sep 14, 2022
b20ece2
Merge branch 'develop' into ios_bgp_duplicate_neighbor
jtishey Oct 21, 2022
98a87e3
Merge branch 'develop' into ios_bgp_duplicate_neighbor
mirceaulinic Mar 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions napalm/ios/ios.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1957,12 +1957,17 @@ def get_bgp_neighbors(self):
# get neighbor_entry out of neighbor data
neighbor_entry = None
for neighbor in neighbor_data:
if (
neighbor["afi"].lower() == afi
and napalm.base.helpers.ip(neighbor["remote_addr"]) == remote_addr
):
neighbor_entry = neighbor
break
current_neighbor = napalm.base.helpers.ip(neighbor["remote_addr"])
if neighbor["afi"].lower() == afi and current_neighbor == remote_addr:
# Neighbor IPs in VRFs can overlap, so make sure
# we haven't covered this VRF + IP already
vrf = neighbor["vrf"] or "global"
if (
vrf == "global"
or current_neighbor not in bgp_neighbor_data[vrf]["peers"]
):
neighbor_entry = neighbor
break
# check for proper session data for the afi
if neighbor_entry is None:
continue
Expand Down
Loading