Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redis interface upgrades #367

Merged
merged 28 commits into from
Sep 8, 2023
Merged

redis interface upgrades #367

merged 28 commits into from
Sep 8, 2023

Conversation

mjrosengrant
Copy link
Collaborator

  • Use native message serialization across redis for best performance and reliability

  • Add flag to SDK session client to return payloads as raw bytes, instead of immediately deserializing

result = await self.request_futs[request_id]
del self.request_futs[request_id]
return result
self._send_message(message_type, args, expects_response)

def update_structures_shallow(self, structures):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this and update_structures_deep still return a future so they can be awaited? since expects_response = True

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed update_structures_deep, but update_structures_shallow doesn't expect a response according to the plugin_instance implementation, so the fix was to set expects_response=False

nanome/beta/redis_interface.py Outdated Show resolved Hide resolved
nanome/beta/redis_interface.py Outdated Show resolved Hide resolved
@mjrosengrant mjrosengrant merged commit 739b088 into master Sep 8, 2023
10 checks passed
@mjrosengrant mjrosengrant deleted the redis-serialize branch September 8, 2023 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants