redis interface upgrades #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjrosengrant
force-pushed
the
redis-serialize
branch
from
b11473e
to
67aae92
Compare
…-lib into redis-serialize
ajm13
approved these changes
Sep 8, 2023
| result = await self.request_futs[request_id] | ||
| del self.request_futs[request_id] | ||
| return result | ||
| self._send_message(message_type, args, expects_response) | ||
|
|
||
| def update_structures_shallow(self, structures): |
There was a problem hiding this comment.
shouldn't this and update_structures_deep still return a future so they can be awaited? since expects_response = True
There was a problem hiding this comment.
fixed update_structures_deep, but update_structures_shallow doesn't expect a response according to the plugin_instance implementation, so the fix was to set expects_response=False
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use native message serialization across redis for best performance and reliability
Add flag to SDK session client to return payloads as raw bytes, instead of immediately deserializing