Improve UpdateNanoCLRInstance #289
Conversation
- Add logging of detail upon failure to update nanoCLR instance. - Minor code improvements from static analysis.
WalkthroughThe pull request modifies the Changes
Assessment against linked issues
Note: The changes in the launch settings do not directly address the verbose output or nanoCLR update issue mentioned in the linked issue. More context or additional changes would be needed to fully resolve the reported problem. Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (2)
poc/NFUnit Test DemoByReference.ChildProcessDbgSettingsis excluded by none and included by nonesource/TestAdapter/NanoCLRHelper.csis excluded by none and included by none
📒 Files selected for processing (1)
source/TestAdapter/Properties/launchSettings.json(1 hunks)
🧰 Additional context used
🪛 Biome (1.9.4)
source/TestAdapter/Properties/launchSettings.json
[error] 8-8: Expected a property but instead found '}'.
Expected a property here.
(parse)
| "commandLineArgs": "E:\\GitHub\\nf-nanoFramework.TestFramework\\poc\\TestOfTestFrameworkByReference\\bin\\Debug\\NFUnitTest.dll /Settings:E:\\GitHub\\nf-nanoFramework.TestFramework\\poc\\TestOfTestFrameworkByReference\\nano.runsettings /TestAdapterPath:E:\\GitHub\\nf-nanoFramework.TestFramework\\source\\TestAdapter\\bin\\Debug\\net48", | ||
| "workingDirectory": "E:\\GitHub\\nf-nanoFramework.TestFramework\\source\\TestAdapter\\bin\\Debug\\net48", |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Consider using relative paths instead of hardcoded local paths
The configuration contains hardcoded absolute paths which:
- Won't work across different developer machines
- Makes the configuration less portable
- Could cause issues in CI/CD environments
Consider using:
- MSBuild variables (e.g.,
$(SolutionDir),$(ProjectDir)) - Relative paths from the project root
- Environment variables
Example approach:
- "commandLineArgs": "E:\\GitHub\\nf-nanoFramework.TestFramework\\poc\\TestOfTestFrameworkByReference\\bin\\Debug\\NFUnitTest.dll /Settings:E:\\GitHub\\nf-nanoFramework.TestFramework\\poc\\TestOfTestFrameworkByReference\\nano.runsettings /TestAdapterPath:E:\\GitHub\\nf-nanoFramework.TestFramework\\source\\TestAdapter\\bin\\Debug\\net48",
- "workingDirectory": "E:\\GitHub\\nf-nanoFramework.TestFramework\\source\\TestAdapter\\bin\\Debug\\net48",
+ "commandLineArgs": "$(SolutionDir)poc\\TestOfTestFrameworkByReference\\bin\\Debug\\NFUnitTest.dll /Settings:$(SolutionDir)poc\\TestOfTestFrameworkByReference\\nano.runsettings /TestAdapterPath:$(ProjectDir)bin\\Debug\\net48",
+ "workingDirectory": "$(ProjectDir)bin\\Debug\\net48",Would you like me to provide more detailed guidance on setting up a portable configuration?
Also applies to: 12-12
| "workingDirectory": "E:\\GitHub\\nf-nanoFramework.TestFramework\\source\\TestAdapter\\bin\\Debug\\net48", | ||
| }, |
There was a problem hiding this comment.
Fix JSON syntax error: Remove trailing comma
There's a trailing comma after the workingDirectory property which is invalid JSON syntax.
Apply this fix:
"workingDirectory": "E:\\GitHub\\nf-nanoFramework.TestFramework\\source\\TestAdapter\\bin\\Debug\\net48",
+ }
- },Committable suggestion skipped: line range outside the PR's diff.
🧰 Tools
🪛 Biome (1.9.4)
[error] 8-8: Expected a property but instead found '}'.
Expected a property here.
(parse)
Description
Motivation and Context
How Has This Been Tested?
Screenshots
Types of changes
Checklist:
Summary by CodeRabbit