Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link boost stacktrace appropriately for line information. #4771

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

Link boost stacktrace appropriately for line information. #4771

wants to merge 5 commits into from

Conversation

clemahieu
Copy link
Contributor

The previous code was overcomplicating a relatively straightforward requirement to link against librt and libdynamic to get symbolic stacktraces.

@clemahieu clemahieu requested a review from pwojcikdev October 27, 2024 15:05
@gr0vity-dev-bot
Copy link

gr0vity-dev-bot commented Oct 27, 2024 •
edited
Loading

Test Results for Commit 99e323b

Pull Request 4771: Results
Overall Status: ❌

Test Case Results

  • ✅ 5n4pr_conf_10k_bintree: PASS (Duration: 114s)
  • ✅ 5n4pr_conf_10k_change: PASS (Duration: 4121s)
  • ❌ 5n4pr_conf_change_dependant: FAIL (Duration: 1022s)
  • Log
  • ✅ 5n4pr_conf_change_independant: PASS (Duration: 128s)
  • ❌ 5n4pr_conf_send_dependant: FAIL (Duration: 132s)
  • Log
  • ✅ 5n4pr_conf_send_independant: PASS (Duration: 117s)
  • ❌ 5n4pr_rocks_10k_bintree: FAIL (Duration: 196s)
  • Log
  • ✅ 5n4pr_rocks_10k_change: PASS (Duration: 161s)

Last updated: 2025-01-29 14:07:32 UTC

@pwojcikdev
Copy link
Contributor

Don't we need add_definitions(-DBOOST_STACKTRACE_USE_BACKTRACE) otherwise a default mode will be used?

@pwojcikdev pwojcikdev force-pushed the boost_stacktrace branch 3 times, most recently from 3ab0ecc to 1a3435b Compare October 28, 2024 16:49
@qwahzi qwahzi added this to the V28 milestone Nov 26, 2024
@pwojcikdev pwojcikdev force-pushed the boost_stacktrace branch 2 times, most recently from 76a7018 to 53d8225 Compare January 28, 2025 09:05
@pwojcikdev
Copy link
Contributor

I was confused why github runners were having problems , but I noticed that in failed run annotations there is this:

Unhandled exception. System.IO.IOException: No space left on device : '/home/runner/runners/2.321.0/_diag/Worker_20250128-155555-utc.log'...

Perhaps the the additional stacktrace processing code pushed our build directory over github limits...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pwojcikdev pwojcikdev Awaiting requested review from pwojcikdev

Assignees
No one assigned
Labels
None yet
Projects
Nano Roadmap
Status: In Progress / V28.0
Milestone
V28
Development

Successfully merging this pull request may close these issues.
4 participants
@clemahieu @gr0vity-dev-bot @pwojcikdev @qwahzi