Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

966 use bevy meshes as nannous rendering backend #968

Conversation

tychedelia
Copy link
Collaborator

@tychedelia tychedelia commented Mar 21, 2024

Another messy diff. But, overall, this works!

Notes:

  • Right now, we are taking the most naive approach for caching meshes, which is just to query and iterate through existing meshes and spawn new ones as needed.
  • A lot of the churn is from switching to use Bevy's color in our public API. Note that this is changing in bevy 0.14, with the addition of lots of new color spaces we'll want to support. Bevy Colors V2 bevyengine/bevy#10986 There's probably more cleanup work we could do here to make things nice.
  • I haven't ripped out the text rendering backend yet, but we'll want to track and switch to this Migrate to cosmic-text bevyengine/bevy#7616.

TODO:

  • Check all primitives still render.

image

@tychedelia tychedelia marked this pull request as ready for review March 25, 2024 02:15
@tychedelia tychedelia merged commit d7b3ddb into nannou-org:bevy-refactor Mar 25, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant