feat: Add character encoding conversion function #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add a function to convert a given string to a specified character encoding - Support various target character encodings (e.g., UTF-8, EUC-KR)
psi59
commented
Jun 1, 2024
| @@ -310,122 +310,118 @@ func (x *xSQLVAR) parseString(raw_value []byte, charset string) interface{} { | |||
| if x.sqlsubtype == 1 { // OCTETS | |||
| return raw_value | |||
| } | |||
| if x.sqlsubtype == 0 { | |||
There was a problem hiding this comment.
When I queried using the attached query, I confirmed that the subtype is 0, but the value of x.sqlsubtype set through the _parse_select_items function was found to be 44. Please check if it's my mistake.
Additionally, is the content of the linked documentation about subtype in Firebird correct?
SELECT REL_FIELDS.RDB$FIELD_NAME, FIELD_SPEC.RDB$FIELD_SUB_TYPE
FROM RDB$FIELDS FIELD_SPEC,
RDB$RELATION_FIELDS REL_FIELDS
WHERE FIELD_SPEC.RDB$FIELD_NAME = REL_FIELDS.RDB$FIELD_SOURCE
AND REL_FIELDS.RDB$RELATION_NAME = 'T'
AND REL_FIELDS.RDB$FIELD_NAME = 'TEXT';
|
Thanks It really looks okay! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First, I apologize for the omission of test code in PR #176.
In this PR, I have added test code. I used for testing is Firebird SS 2.5.
Changes