-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python 3.7, 3.8 support, improved unittest support #7
base: master
Are you sure you want to change the base?
Conversation
…test suites to increase test throughput.
…supported constructs
I totally forgot I forked it with that fix 😆 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This WFM on Python 3.8-3.10.0b3, on Mac BigSur 11.4
@@ -0,0 +1,256 @@ | |||
# py2rb.py |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing README.rst and creating README.md causes pip install 'git+https://github.com/nanobowers/py2rb@new_versions'
to fail because setup.py requires README.rst
.
ping @naitoh , could you review this. I would like to make other PRs, but it doesnt make sense to do that unless this is merged as I need py38+ support. |
Hi @jayvdb, I am hopeful that @naitoh returns, but it appears he has been inactive for quite some time. I have recently made some fixes to my repo that address some of the issues you filed:
Please feel free to submit issues/PRs there if you wish. Hopefully we can get clarification if this repo is abandoned and (if so) figure out if it can be handed off to someone else. |
Great. There are now two main bugs found by the py2many test suite
And one that is not as critical
I think I saw that @naitoh was active on Twitter. Might want to catch him there or on email, to find out the future of this package. |
This PR also contains some edits based on a fork from @Fryguy - namely support for F-Strings.
Enhancements: