fix: remove unused config of google client id/secret

nais · Nov 7, 2024 · 2325c15 · 2325c15
1 parent e78f10e
commit 2325c15
Show file tree

Hide file tree

Showing 4 changed files with 1 addition and 18 deletions.
diff --git a/charts/hookd/Chart.yaml b/charts/hookd/Chart.yaml
@@ -4,4 +4,4 @@ name: hookd
 description: Receives deploy instructions, verifies authenticity and sends to deployd in the desired cluster.
 sources:
   - https://github.com/nais/deploy/tree/master/charts/hookd
-version: 0.0.1
+version: 0.0.2
diff --git a/charts/hookd/Feature.yaml b/charts/hookd/Feature.yaml
@@ -51,15 +51,6 @@ values:
   deploydPreSharedKeys:
     computed:
       template: '"{{ eachOf .Envs "deployd_pre_shared_key" | join "," }}"'
-  googleClient.id:
-    description: Google OAuth 2.0 Client ID, see https://handbook.nais.io/technical/tenant-setup/#set-up-oauth-client
-    config:
-      type: string
-  googleClient.secret:
-    description: Google OAuth 2.0 Client Secret, see https://handbook.nais.io/technical/tenant-setup/#set-up-oauth-client
-    config:
-      type: string
-      secret: true
   ingress.host:
     displayName: Ingress URL
     computed:

diff --git a/charts/hookd/values.yaml b/charts/hookd/values.yaml
@@ -7,9 +7,6 @@ ingress:
   className: "nais-ingress-external"
 
 deploydPreSharedKeys: # mapped by fasit
-googleClient:
-  id: # mapped by fasit
-  secret: # mapped by fasit
 
 logLinkFormatter: "GCP"
 otelExporterOtlpEndpoint: # mapped by fasit

diff --git a/pkg/hookd/config/config.go b/pkg/hookd/config/config.go
@@ -24,7 +24,6 @@ type Config struct {
 	FrontendKeys              []string      `json:"frontend-keys"`
 	GRPC                      GRPC          `json:"grpc"`
 	GoogleAllowedDomains      []string      `json:"google-allowed-domains"`
-	GoogleClientId            string        `json:"google-client-id"`
 	GoogleClusterProjects     []string      `json:"google-cluster-projects"`
 	ListenAddress             string        `json:"listen-address"`
 	LogFormat                 string        `json:"log-format"`
@@ -45,7 +44,6 @@ const (
 	DeploydKeys               = "deployd-keys"
 	FrontendKeys              = "frontend-keys"
 	GoogleAllowedDomains      = "google-allowed-domains"
-	GoogleClientId            = "google-client-id"
 	GoogleClusterProjects     = "google-cluster-projects"
 	GrpcAddress               = "grpc.address"
 	GrpcCliAuthentication     = "grpc.cli-authentication"
@@ -69,8 +67,6 @@ func bindNAIS() {
 
 	viper.BindEnv(DeploydKeys, "DEPLOYD_KEYS")
 	viper.BindEnv(FrontendKeys, "FRONTEND_KEYS")
-
-	viper.BindEnv(GoogleClientId, "GOOGLE_CLIENT_ID")
 }
 
 func Initialize() *Config {
@@ -99,7 +95,6 @@ func Initialize() *Config {
 	flag.StringSlice(DeploydKeys, nil, "Pre-shared deployd keys, comma separated")
 	flag.StringSlice(FrontendKeys, nil, "Pre-shared frontend keys, comma separated")
 
-	flag.String(GoogleClientId, "", "Google ClientId.")
 	flag.StringSlice(GoogleAllowedDomains, []string{}, "Allowed Google Domains")
 	flag.StringSlice(GoogleClusterProjects, []string{}, "Mapping cluster to google project: cluster1=project1,cluster2=project2")