Skip to content

Commit

Permalink
Ensure generated release apk filename indicates it's heavyweight
Browse files Browse the repository at this point in the history
Github build currently for some reason does not strip debug symbols in ndk built libs. So they are unnecessarily heavy. 

Mark the uploaded release assets as such. 
Will manually upload locally built apks additionally for time being.
  • Loading branch information
nain-F49FF806 authored Jul 11, 2024
1 parent a950cbd commit 6d99bb0
Showing 1 changed file with 4 additions and 10 deletions.
14 changes: 4 additions & 10 deletions .github/workflows/android.yml
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ jobs:
SIGNING_KEY_PASSWORD: ${{ secrets.SIGNING_KEY_PASSWORD }}
SIGNING_STORE_PASSWORD: ${{ secrets.SIGNING_STORE_PASSWORD }}

- name: Upload apk to release assets
- name: Upload apks to release assets
if: ${{ (github.event_name == 'release') }}
run: |
curl --fail -L \
Expand All @@ -97,29 +97,23 @@ jobs:
-H "Authorization: Bearer ${{ secrets.RELEASE_UPLOAD_PAT }}" \
-H "X-GitHub-Api-Version: 2022-11-28" \
-H "Content-Type: application/octet-stream" \
"https://uploads.github.com/repos/${{ github.repository }}/releases/${{ github.event.release.id }}/assets?name=sharepaste.oo-source-original-arm64-v8a-release.apk" \
"https://uploads.github.com/repos/${{ github.repository }}/releases/${{ github.event.release.id }}/assets?name=sharepaste.oo-source-original-arm64-v8a-release.unstrippedlibs.apk" \
--data-binary "@android/app/build/outputs/apk/source-original/release/sharepaste.oo-source-original-arm64-v8a-release.apk"
- name: Upload apk to release assets
if: ${{ (github.event_name == 'release') }}
run: |
curl -L \
-X POST \
-H "Accept: application/vnd.github+json" \
-H "Authorization: Bearer ${{ secrets.RELEASE_UPLOAD_PAT }}" \
-H "X-GitHub-Api-Version: 2022-11-28" \
-H "Content-Type: application/octet-stream" \
"https://uploads.github.com/repos/${{ github.repository }}/releases/${{ github.event.release.id }}/assets?name=sharepaste.oo-source-original-armeabi-v7a-release.apk" \
"https://uploads.github.com/repos/${{ github.repository }}/releases/${{ github.event.release.id }}/assets?name=sharepaste.oo-source-original-armeabi-v7a-release.unstrippedlibs.apk" \
--data-binary "@android/app/build/outputs/apk/source-original/release/sharepaste.oo-source-original-armeabi-v7a-release.apk"
- name: Upload apk to release assets
if: ${{ (github.event_name == 'release') }}
run: |
curl -L \
-X POST \
-H "Accept: application/vnd.github+json" \
-H "Authorization: Bearer ${{ secrets.RELEASE_UPLOAD_PAT }}" \
-H "X-GitHub-Api-Version: 2022-11-28" \
-H "Content-Type: application/octet-stream" \
"https://uploads.github.com/repos/${{ github.repository }}/releases/${{ github.event.release.id }}/assets?name=sharepaste.oo-source-original-universal-release.apk" \
"https://uploads.github.com/repos/${{ github.repository }}/releases/${{ github.event.release.id }}/assets?name=sharepaste.oo-source-original-universal-release.unstrippedlibs.apk" \
--data-binary "@android/app/build/outputs/apk/source-original/release/sharepaste.oo-source-original-universal-release.apk"
- name: Upload Build Artifacts (Apks)
Expand Down

0 comments on commit 6d99bb0

Please sign in to comment.