Skip to content

Commit

Permalink
Merge pull request #138 from n8thangreen/main
Browse files Browse the repository at this point in the history
Main back to dev
  • Loading branch information
n8thangreen authored Aug 9, 2023
2 parents cf868d2 + 84657f9 commit 64beea7
Show file tree
Hide file tree
Showing 5 changed files with 15 additions and 34 deletions.
6 changes: 3 additions & 3 deletions CRAN-SUBMISSION
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
Version: 2.4.3
Date: 2023-05-02 15:57:14 UTC
SHA: 849eaea3529ff1cdbddbd3e537c66e9b2da26194
Version: 2.4.4
Date: 2023-06-05 11:24:02 UTC
SHA: 315d3e90d9c230d5ea30b5e5540e1943398ab87e
2 changes: 1 addition & 1 deletion DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
Package: BCEA
Type: Package
Title: Bayesian Cost Effectiveness Analysis
Version: 2.4.3
Version: 2.4.4
Authors@R: c(
person("Gianluca", "Baio",
email = "[email protected]",
Expand Down
5 changes: 5 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,9 @@

# BCEA 2.4.4
June 2023

* Patch to fix a CRAN checks error. Suggested package `MCMCvis` wasn't used conditionally in unit test. Moved to Required packages in `DESCRIPTION`.

# BCEA 2.4.3
May 2023

Expand Down
8 changes: 4 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -34,12 +34,12 @@ Main features of `BCEA` include:
* EVPPI calculations and plots

## Installation
Install the [released version from CRAN](https://cran.r-project.org/web/packages/BCEA/index.html) with
Install the [released version from CRAN](https://cran.r-project.org/package=BCEA) with
```r
install.packages("BCEA")
```

The development version can be installed using this GitHub repository. On Windows machines, you need to install a few dependencies, including [Rtools](https://cran.r-project.org/bin/windows/Rtools/) first, e.g. by running
The stable version (which can be updated more quickly) can be installed using this GitHub repository. On Windows machines, you need to install a few dependencies, including [Rtools](https://cran.r-project.org/bin/windows/Rtools/) first, e.g. by running

```r
pkgs <- c("MASS", "Rtools", "remotes")
Expand All @@ -49,13 +49,13 @@ install.packages(pkgs, repos=repos, dependencies = "Depends")
before installing the package using `remotes`:

```r
remotes::install_github("giabaio/BCEA", ref="dev")
remotes::install_github("giabaio/BCEA")
```
Under Linux or MacOS, it is sufficient to install the package via `remotes`:

```r
install.packages("remotes")
remotes::install_github("giabaio/BCEA", ref="dev")
remotes::install_github("giabaio/BCEA")
```

## Articles
Expand Down
28 changes: 2 additions & 26 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,30 +1,8 @@

# Resubmission (2.4.3)
# Resubmission (2.4.4)

* compute.evppi() was mismatched with the dplyr compute() function. We've changed the
function name to compute_evppi() to avoid confusion since it is only an internal function.
* Suggested package wasn't used conditionally in unit test causing CRAN check error. `MCMCvis` is now moved to Required packages.

CHECK message:

Flavor: r-devel-linux-x86_64-debian-gcc
Check: S3 generic/method consistency, Result: NOTE
Mismatches for apparent methods not registered:
compute:
function(x, ...)
compute.evppi:
function(he, fit.full)

* Similarly, the internal function plot.mesh() is not a plot method but was being considered so,
so we have renamed to plot_mesh()

CHECK message:

plot:
function(x, ...)
plot.mesh:
function(mesh, data, plot)
See section 'Registering S3 methods' in the 'Writing R Extensions'
manual.

## R CMD check results

Expand All @@ -50,5 +28,3 @@ We checked 2 reverse dependencies (missingHE, heesim), comparing R CMD check res
* We saw 0 new problems
* We failed to check 0 packages



0 comments on commit 64beea7

Please sign in to comment.