This repository has been archived by the owner on Nov 10, 2017. It is now read-only.
React 0.14 #33
Open
React 0.14 #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rename js file to jsx remove jsx pragma update project dependencies update to react v0.14 api
|
🎂 @n1k0 |
|
Thanks :) You well deserved a review today o/ |
| "indent": [ | ||
| 2, | ||
| 2 | ||
| ], |
There was a problem hiding this comment.
Please format it this way: "indent": [2, 2],
|
|
||
| describe("KeptTodo", function() { | ||
| var comp, fakeUpdate; | ||
|
|
||
| function renderWithProps(props) { | ||
| return TestUtils.renderIntoDocument(KeptTodo(props)); | ||
| return TestUtils.renderIntoDocument( <KeptTodo {...props} />); |
|
Man, this looks super good. I have to switch to other tasks so I didn't take the time to run the app locally, will do asap. Great work! Cheers |
|
side note |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP still some issue probably due to
<Modal />when usedrenderIntoDocument()other tests are greens !
Do you mind take a look if it is going in the good direction ?