Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Week 4 #8

Merged
merged 14 commits into from
Apr 20, 2019
Merged

Week 4 #8

merged 14 commits into from
Apr 20, 2019

Conversation

mzadrazi
Copy link
Owner

No description provided.

developer239
developer239 requested changes Apr 15, 2019
View reviewed changes
Copy link
Collaborator

@developer239 developer239 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job. 💪 Now with redux and form and proper authorization, this is a really good foundation for future React applications. I believe refactoring with HOCs, Render Props and Hooks will be fun. 🙂

src/components/Button/index.js Show resolved Hide resolved
src/components/Layout/index.js Outdated Show resolved Hide resolved
src/components/PrivateRoute/index.js Outdated Show resolved Hide resolved
src/store/userSession/index.js Outdated Show resolved Hide resolved
src/pages/Login/index.js Outdated Show resolved Hide resolved
src/api/login.js Outdated Show resolved Hide resolved
src/api/apiClient.js Outdated Show resolved Hide resolved
developer239
developer239 approved these changes Apr 20, 2019
View reviewed changes
Copy link
Collaborator

@developer239 developer239 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 💪 It is nice to see that you took the extra time and implemented redux-thunk. 🙂

@mzadrazi mzadrazi merged commit abe4644 into 04-Forms Apr 20, 2019
@mzadrazi mzadrazi deleted the week-4 branch April 27, 2019 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@developer239 developer239 developer239 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mzadrazi @developer239