Add pipeline.Clone and p.Run(data interface{}) to allow reusable pipe… #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 13, 2017 22:41
…lines. Accept function as a step to allow cloning of stateless pipelines
added 2 commits
September 15, 2017 11:12
… merge results from multiple concurrent steps
|
Looks good to me so far. The only thing I don't really understand is changing the output data type to byte slice from string. JSON can be represented as string, can't it? What's the ultimate goal here: output anything and let the user take care or output something that can be processed as some text format? Anyway, I would probably add a helper function (StatusString) to make reporting status easier. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Incomplete PR for brainstorming.