Changed the default icon ID to 32512 to be in line with the Windows default.
#39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #28.
I think it's absolutely reasonable to change the default to match what Windows expects as the default. Users of this crate will expect
winresto be a canonical source of information, and using a default value of1just because other exes weren't using the Windows default doesn't make sense to me.I also found a Windows property called
DefaultIconResourceId, and it's also set to32512: https://docs.microsoft.com/en-us/previous-versions/windows/desktop/cc982301(v=vs.85)