Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default icon id should be 32512 #28

Closed
lucasfernog opened this issue Dec 5, 2020 · 2 comments · May be fixed by #39
Closed

Default icon id should be 32512 #28

lucasfernog opened this issue Dec 5, 2020 · 2 comments · May be fixed by #39

Comments

@lucasfernog
Copy link

https://docs.microsoft.com/en-us/windows/win32/api/winuser/nf-winuser-loadicona

When using the LoadIcon API, IDI_APPLICATION looks for id 32512: MAKEINTRESOURCE(32512)
@mxre
Copy link
Owner

mxre commented Sep 28, 2021

Every Example I've seen uses id 1 for the program icon in the resource files. Additionally I've looked at several exes on my disks and almost all use 1 as the primary icon id.
You can use LoadIcon with the Id 1, or alternatively add an Icon with the Id of 32512 using WindowResource:set_icon_with_id

@mxre mxre closed this as completed Sep 28, 2021
@zedseven
Copy link

zedseven commented Sep 28, 2021 •
edited
Loading

All executables built by Visual Studio/.NET with embedded icons use the icon ID 32512.
I would consider Visual Studio to be a canonical source of Microsoft standards when it comes to default icon ID.

image
(using IconViewer to check icon ID)

zedseven added a commit to zedseven/winres that referenced this issue Jan 9, 2022
@zedseven
Changed the default icon ID to 32512 to be in line with the Windows…
99d4e06 
… default. Fixes mxre#28.
@zedseven zedseven mentioned this issue Jan 9, 2022
Open
@BenjaminRi BenjaminRi mentioned this issue Nov 20, 2022
Closed
FabianLars added a commit to tauri-apps/winres that referenced this issue Jan 5, 2023
@FabianLars
Merge pull request #3 from zedseven/master
fec3ee0 
Changed the default icon ID to `32512` to be in line with the Windows default, ref mxre#28
@zedseven zedseven mentioned this issue Jul 20, 2023
Merged
@fredizzimo fredizzimo mentioned this issue Mar 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Changed the default icon ID to 32512 to be in line with the Windows default. zedseven/winres
3 participants
@mxre @lucasfernog @zedseven