Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change hardcoded reference; update example for cards with bigger UIDs #23

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dirkx
Copy link

@dirkx dirkx commented Mar 23, 2016

Change hardcoded reference to pin22/GPIO25 to the constant; update example code to show the entire card UID (rather than just the first four digits)

…ample code to show the entire card UID (rather than just the first four digits)
@buzai
Copy link

buzai commented Apr 28, 2016

i have a question , in pi3, pin22 is gpio6 , can i use this code . now it is not work.

@LudwigKnuepfer
Copy link

Compare #36

GPIO.setup(22, GPIO.OUT)
GPIO.setup(self.NRSTPD, GPIO.OUT)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This hunk seems already taken care of in 6896370 (and a follow up to make it actually work (cf7f9ec, #52)

Comment on lines -35 to +37
print "Card detected"
localtime = time.asctime( time.localtime(time.time()) )
print "Card detected " + localtime
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is an unrelated change that deserves a separate commit

@@ -59,3 +62,4 @@ def end_read(signal,frame):
else:
print "Authentication error"

time.sleep(10)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this good for?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants