Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add additional descriptions of the device #193

Open
wants to merge 5 commits into
base: next
Choose a base branch
from
Open

Add additional descriptions of the device #193

wants to merge 5 commits into from

Conversation

moritzstaffel
Copy link
Contributor

Implements #45

@moritzstaffel moritzstaffel self-assigned this Apr 18, 2024
@moritzstaffel moritzstaffel changed the base branch from main to next April 18, 2024 12:28
@moritzstaffel
Copy link
Contributor Author

Summery of discussion:
The distance need more definition, as it is not clear what they actually do and how do we define this.
Laser, CO2 Cannon, Pyro: Do they need this as well.

moritzstaffel
moritzstaffel commented Apr 25, 2024
View reviewed changes
gdtf-spec.md
| XML Attribute Name | Value Type | Description |
|----|----|----|
| IPRating | [String](#user-content-attrtype-string ) | IP Rating of the device of the format of IEC 60529. Example: IP65 |
| DistanceToFlammable | [Float](#user-content-attrtype-float ) | Minimal distance in meter from flammable objects; Default value: 0 |
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't do the DistanceToFlammable

moritzstaffel
moritzstaffel commented Apr 25, 2024
View reviewed changes
gdtf-spec.md
|----|----|----|
| IPRating | [String](#user-content-attrtype-string ) | IP Rating of the device of the format of IEC 60529. Example: IP65 |
| DistanceToFlammable | [Float](#user-content-attrtype-float ) | Minimal distance in meter from flammable objects; Default value: 0 |
| DistanceToIlluminated | [Float](#user-content-attrtype-float ) | Minimal distance in meter from other objects; Default value: 0 |
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DistanceToTarget

Minimal distance to the target of the device. For Lasers, WaterFountains, Audio and Lighting devices.

@petrvanekrobe
Copy link
Contributor

  • Robe defined data: Min. distance from flammable materials: 1 m is a required information about distance from flammable materials based on surface temperature of the fixture's housing. This is defined in EN IEC 60598-2-17 part 2-17, section 17.6.4 - minimal distance from flammable materials of all outer surfaces of the device.

  • Robe defined data: Min. distance of illuminated objects: 18 m is a required information about distance on which the fixture could make illuminated surface warmer then 90°. This is defined in EN IEC 60598-1, part 1, section 3.2.13. Often accommodated by this picture:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@moritzstaffel moritzstaffel

Labels
gdtf spec in work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@moritzstaffel @petrvanekrobe