Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement Mux badge #988

Merged
merged 19 commits into from
Jan 13, 2025
Merged

feat: implement Mux badge #988

merged 19 commits into from
Jan 13, 2025

Conversation

davekiss
Copy link
Contributor

@davekiss davekiss commented Sep 19, 2024

Adds proudly-display-mux-badge attribute to render a linkback to Mux

Video demo: https://cln.sh/wjpPRNXD

See the bottom player in the example deployment: https://elements-demo-vanilla-git-fork-davekiss-dk-powered-by-mux.vercel.app/mux-player.html

@davekiss davekiss requested a review from a team as a code owner September 19, 2024 19:05
Copy link

vercel bot commented Sep 19, 2024

@davekiss is attempting to deploy a commit to the Mux Team on Vercel.

A member of the Team first needs to authorize it.

@dylanjha
Copy link
Contributor

Such a good idea!

Copy link

vercel bot commented Sep 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
elements-demo-astro ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 13, 2025 6:08pm
elements-demo-create-react-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 13, 2025 6:08pm
elements-demo-nextjs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 13, 2025 6:08pm
elements-demo-svelte-kit ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 13, 2025 6:08pm
elements-demo-vanilla ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 13, 2025 6:08pm
elements-demo-vue ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 13, 2025 6:08pm

Copy link

codecov bot commented Sep 21, 2024

Codecov Report

Attention: Patch coverage is 91.26984% with 11 lines in your changes missing coverage. Please review.

Project coverage is 80.68%. Comparing base (76aa003) to head (eadc94c).
Report is 51 commits behind head on main.

Files with missing lines Patch % Lines
packages/mux-player/src/index.ts 38.88% 11 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #988      +/-   ##
==========================================
- Coverage   81.67%   80.68%   -0.99%     
==========================================
  Files          40       41       +1     
  Lines        8571     9711    +1140     
  Branches      470      504      +34     
==========================================
+ Hits         7000     7835     +835     
- Misses       1565     1876     +311     
+ Partials        6        0       -6     
Flag Coverage Δ
80.68% <91.26%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
packages/mux-player/src/template.ts 94.67% <100.00%> (-0.27%) ⬇️
packages/mux-player/src/themes/gerwig/gerwig.html 100.00% <100.00%> (ø)
packages/mux-player/src/index.ts 72.98% <38.88%> (+0.42%) ⬆️

... and 17 files with indirect coverage changes

Copy link
Contributor

@cjpillsbury cjpillsbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like there's still some lingering issues here

@davekiss
Copy link
Contributor Author

davekiss commented Jan 8, 2025

@cjpillsbury turns out the BooleanRenderer is required for the URL query param to work

@davekiss davekiss requested a review from cjpillsbury January 8, 2025 12:22
@cjpillsbury
Copy link
Contributor

Still not working right. Prop is properly getting passed down as an attr to the <mux-player> web component but not getting set on the template. I can look into this if needed.

Screenshot 2025-01-08 at 9 15 39 AM

Copy link

Ship Mux Player badge

Copy link
Contributor

@luwes luwes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
make sure tests pass

@davekiss davekiss merged commit 2343df8 into muxinc:main Jan 13, 2025
5 of 11 checks passed
@github-actions github-actions bot mentioned this pull request Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants