Remove scrobble from Subsonic provider #1904
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has only ever caused bugs and now that we have folks writing scrobbling plugins that is the place it should happen. Signed-off-by: Eric B Munson <[email protected]>
Because these files can store some of their metadata at the end of the file and we can't just hand a URL to ffmpeg to pull from (due to subsonic API) we will fail to play M4A files with the moov atom at the back. Add a warning in the logs when this is attempted. Signed-off-by: Eric B Munson <[email protected]>
marcelveldt
reviewed
Jan 23, 2025
| @@ -827,7 +829,7 @@ def _streamer() -> None: | |||
| timeOffset=seek_position, | |||
| estimateContentLength=True, | |||
| ) as stream: | |||
| for chunk in stream.iter_content(chunk_size=40960): | |||
| for chunk in stream.iter_content(chunk_size=4096): | |||
There was a problem hiding this comment.
Any particular reason to choose such a small chunk size ?
I would rather raise it then lower it. Something like 32kb or even higher.
There was a problem hiding this comment.
Damn, that was not supposed to be left in (I was testing to see if different chunk sizes changed seek performance, they don't AFAICT). We currently use 40Kb as a chunk size and I'll leave that alone if you agree.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit disables scrobbling in the music provider so we don't step on the scrobble providers. The second adds a warning when a user plays an MPEG-4 file referencing our documentation on the possible problem.