Fix: Deezer tracks that have been replaced with a newer version fail to play #1892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcelveldt
approved these changes
Jan 20, 2025
|
ah the linter found a small issue, can you correct please ? |
…to play Some tracks have been replaced by a newer version. When this happens, the old track information stays available but it will fail to play because the stream has become invalid. Fortunately, the playback API provides the track replacement in a "FALLBACK" entry. So when we encounter a track that has a "FALLBACK" entry, use the information from that entry rather than the main track entry for the stream. Fixes music-assistant/support#3466
|
Should be fixed now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some tracks have been replaced by a newer version. When this happens, the old track information stays available but it will fail to play because the stream has become invalid. Fortunately, the playback API provides the track replacement in a "FALLBACK" entry. So when we encounter a track that has a "FALLBACK" entry, use the information from that entry rather than the main track entry for the stream.
Fixes music-assistant/support#3466