Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch does the following:
idfield_value
function which incorrectly captured the 16-24th bits instead of the 8-16th bitsswapfield
value of theAddressSelect
registerread_rdram_dram_corrupted
for the dram address likeread_rdram_dram
hasmapping.end
value inmap_corrupt_rdram
to match the one indevice.c
This patch allows the libdragon IPL to boot without using hacks like setting the
RI_SELECT
register to a nonzero value or checking which register is targeted by a broadcast.I want to thank @rasky for helping me debug some issues.
You can test this code using a simple n64-systemtest build with the libdragon IPL which only runs 1 test: n64-systemtest.zip
You can view the documentation here: