Fix incorrect maximum ROM size

[Rosalie241]

This allows ROMs larger than 64MiB to work in mupen64plus.

Tested with the following ROMs:

• The Big Buck Bunny demo from PeterLemon
• dmatest

You can find documentation about the console limitations here:

• https://n64brew.dev/wiki/Memory_map
• https://n64brew.dev/wiki/FAQ

Fixes #997
Fixes #1101

[Jj0YzL5nvJ]

This is much better than the previous attempt #685

Looking at your latest modifications, there seems to be a lot more "limits" to change... I can't be of much help in that regard.
Add this ROM to your tests, in my case it always soft freeze (my ParaLLEl RDP/RSP forks are too old =P) on the same part... I don't know if it works with Ares or some other emulator. The ideal would be to test it with EverDrive or something similar.

[loganmc10]

I would also make sure to check that Paper Mario still works (and that it can save). I remember it did something where it wrote outside the cart address space, but maybe I'm remembering wrong

[GhostlyDark]

I would also make sure to check that Paper Mario still works (and that it can save). I remember it did something where it wrote outside the cart address space, but maybe I'm remembering wrong

Just tested, saving works fine.

[GhostlyDark]

This is much better than the previous attempt #685

Looking at your latest modifications, there seems to be a lot more "limits" to change... I can't be of much help in that regard. Add this ROM to your tests, in my case it always soft freeze (my ParaLLEl RDP/RSP forks are too old =P) on the same part... I don't know if it works with Ares or some other emulator. The ideal would be to test it with EverDrive or something similar.

It does work with Angrylion (fine) and Parallel RDP (glitches), but only with Parallel RSP. Other RSP plugins just freeze on boot.

[Jj0YzL5nvJ]

It pass with this build: https://github.com/Rosalie241/RMG/actions/runs/12344405888

But the same build fails with the CI cores: https://github.com/mupen64plus/mupen64plus-core/actions?query=branch%3Afix-romsize

That ROM seems to be extremely sensitive to compiler optimizations...

[Rosalie241]

It pass with this build: https://github.com/Rosalie241/RMG/actions/runs/12344405888

But the same build fails with the CI cores: https://github.com/mupen64plus/mupen64plus-core/actions?query=branch%3Afix-romsize

That ROM seems to be extremely sensitive to compiler optimizations...

It plays back fully for you without issues? on Fedora it hangs eventually for me when built locally sadly, though now that you mention compiler optimizations, I've had issues with that before while working on improving FPU accuracy, which is extremely frustrating.

[Jj0YzL5nvJ]

It plays back fully for you without issues?

Only on Windows and Wine with this configuration...

[Rosalie241]

It plays back fully for you without issues?

Only on Windows and Wine with this configuration...

Thank you, I can confirm it plays fully with paraLLEl RSP and angrylion-rdp-plus on Windows

I can also confirm it works on Linux:

I can also confirm saving in Paper Mario works fine still.

[Rosalie241]

Thanks to the help of @GhostlyDark, we managed to find a solution to the unreliable behavior, it was a mistake I made.

@Jj0YzL5nvJ can you test it again with the latest changes? It works for GhostlyDark and me fine now.

[Jj0YzL5nvJ]

Excellent, runs perfect. Even with my deprecated ParaLLEl RDP/RSP forks =P