Be able to handle 1k SNMP plugins #981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This needs to be updated to the latest developments from master |
Adding a 'cap' sub-argument to 'config' to signal 3.0+ plugins that they don't need to do any expensive stuff. They are only called by the initial node config to understand their capabilities
steveschnepp
force-pushed
the
1k-nodes
branch
from
a8b7021
to
6d7b0b2
Compare
Pull Request Test Coverage Report for Build 6761656552
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This isn't only related to SNMP. It is only aimed at SNMP since they're typically slow for config, as they remotely ask their config.
Therefore any plugin that has a slow config with impede the node startup speed.
Here we'll add an optional config sub command to signal that we don't need the whole config output. Only the hostname part to know if it is a remote plugin or a local one